Bug 5744 - Remove rdp2vnc and uiports from the rdesktop project
Summary: Remove rdp2vnc and uiports from the rdesktop project
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: | rdesktop (deprecated) (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.9.0
Assignee: Henrik Andersson
URL:
Keywords: prosaic, samuel_tester
Depends on:
Blocks:
 
Reported: 2015-12-07 14:07 CET by Peter Åstrand
Modified: 2017-12-18 16:22 CET (History)
2 users (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Peter Åstrand cendio 2015-12-07 14:07:40 CET 
The rdesktop project contains a module called "rdp2vnc", as well as several "uiports". None of these are maintained. Therefore, we should remove them.
Comment 1 Karl Mikaelsson cendio 2017-10-17 12:15:40 CEST 
rdp2vnc was removed in upstream commit 8586cfc8cb2734f66fbe737c93d06239c172c300.
Comment 3 Karl Mikaelsson cendio 2017-12-12 18:43:08 CET 
Solved through vendor drop r32951.
Comment 4 Samuel Mannehed cendio 2017-12-18 16:22:57 CET 
Looks good. There are two mentions of uiports still present in the code, but Henrik explained that these are OK since xwin.c is still a "uiport" and the ones that were removed were old alternatives.

$ svn grep uiports
./rdesktop/rdp.c:/* used in uiports and rdp_main_loop, processes the RDP packets waiting */
./rdesktop/xwin.c:/* these do nothing here but are used in uiports */
Note You need to log in before you can comment on or make changes to this bug.