Bug 5722 - shadowing normalizes usernames to lowercase for all comparisons
Summary: shadowing normalizes usernames to lowercase for all comparisons
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: VSM Server (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Critical
Target Milestone: 4.8.0
Assignee: Samuel Mannehed
URL:
Keywords: focus_shadowing, relnotes
Depends on:
Blocks:
 
Reported: 2015-11-23 13:15 CET by Karl Mikaelsson
Modified: 2017-03-21 10:35 CET (History)
2 users (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Karl Mikaelsson cendio 2015-11-23 13:15:56 CET 
Given users a and A, with /vsmserver/allowed_shadowers=a: 

vsmcommon.py:VSMServerHandler:allowed_shadower will allow A to shadow sessions, even though the configuration file does not list A as an allowed shadower.
Comment 1 Pierre Ossman cendio 2016-06-29 10:32:18 CEST 
Possibly related to bug 2884?
Comment 4 Pierre Ossman cendio 2017-01-03 11:08:44 CET 
Works well now. Tested with both case sensitive and case-insensitive backends. ThinLinc respects case when the backend does.

Note however that shadowing case-insensitive users is still broken. We probably need to fix bug 2754 for that.
Comment 5 Pierre Ossman cendio 2017-01-04 10:39:47 CET 
(In reply to comment #4)
> Note however that shadowing case-insensitive users is still broken. We probably
> need to fix bug 2754 for that.

That was actually caused by bug 5174. However the current method is not overly robust, so bug 2754 would still be a better way to handle things.
Comment 6 Bojan Memetovic cendio 2017-01-16 14:22:48 CET 
Works well. Tested with following scenarios: 
USER -> user (can shadow)
user -> USER (can shadow)
a->A (can shadow)
A->a (can shadow)
Comment 7 Bojan Memetovic cendio 2017-01-16 14:50:03 CET 
(In reply to comment #6)
> Works well. Tested with following scenarios: 
> USER -> user (can shadow)
> user -> USER (can shadow)
> a->A (can shadow)
> A->a (can shadow)

Tested even when user A don't have access to shadow user a and vice versa.
Works as expected in accordance with the configuration /vsmserver/allowed_shadowers
Note You need to log in before you can comment on or make changes to this bug.