Bug 5717 - module-tunnel-autoconnect loads both sink+source modules when one sink/source module are unloaded
Summary: module-tunnel-autoconnect loads both sink+source modules when one sink/source...
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Sound (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.6.0
Assignee: Pierre Ossman
URL:
Keywords: hean01_tester, relnotes
Depends on:
Blocks:
 
Reported: 2015-11-17 17:31 CET by Karl Mikaelsson
Modified: 2016-04-12 12:50 CEST (History)
2 users (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Karl Mikaelsson cendio 2015-11-17 17:31:26 CET 
In some circumstances*, this can lead to PulseAudio running out of file descriptors, entering a tight loop and spewing about ~1MB/s data into xinit.log. We should probably only reload both modules if both modules are actually unloaded. Each module consumes about ~10 file descriptors and PulseAudio limits itself to 256 file descriptors, so it's fairly easy to reach that limit.

*: Issue 17983, or by "pactl unload-module" on loaded sink or source modules.

Typical error messages in xinit.log:

> E: [tunnel-source] module-tunnel-source-new.c: Stream failed: Entity killed
> E: [tunnel-source] module-tunnel-source-new.c: Stream failed: Invalid argument
[repeats ~20 times]
> E: [tunnel-source] shm.c: shm_open() failed: Too many open files
[repeats ~400 times]
> W: [tunnel-source] authkey.c: Failed to open cookie file '/var/opt/thinlinc/sessions/user/33/pulse-cookie': Too many open files
> W: [tunnel-source] authkey.c: Failed to load authentication key '/var/opt/thinlinc/sessions/user/33/pulse-cookie': Too many open files
> W: [tunnel-source] client-conf.c: Failed to load cookie from /var/opt/thinlinc/sessions/user/33/pulse-cookie (configured with environment variable PULSE_COOKIE): Too many open files
> W: [tunnel-source] authkey.c: Failed to open cookie file '/var/opt/thinlinc/sessions/user/33/pulse-cookie': Too many open files
> W: [tunnel-source] authkey.c: Failed to load authentication key '/var/opt/thinlinc/sessions/user/33/pulse-cookie': Too many open files
> W: [tunnel-source] client-conf.c: Failed to load cookie from /var/opt/thinlinc/sessions/user/33/pulse-cookie (configured by the application): Too many open files
> W: [tunnel-source] authkey.c: Failed to open cookie file '/home/user/.config/pulse/cookie': Too many open files
> W: [tunnel-source] authkey.c: Failed to load authentication key '/home/user/.config/pulse/cookie': Too many open files
> W: [tunnel-source] authkey.c: Failed to open cookie file '/home/user/.config/pulse/cookie': Too many open files
> W: [tunnel-source] authkey.c: Failed to load authentication key '/home/user/.config/pulse/cookie': Too many open files
> E: [tunnel-source] client-conf.c: Failed to load cookie file from cookie: Too many open files
Comment 2 Henrik Andersson cendio 2015-11-20 16:10:27 CET 
Verified using thinlinc build 4948.

The new tunnel-autoconnect module behaves properly when a sink/source has been unloaded. An unloaded module will silently be loaded upon a reconnection to a session.
Note You need to log in before you can comment on or make changes to this bug.