Bug 5708 - tlclient.cgi generated client configuration file ends with "</BODY></HTML>"
Summary: tlclient.cgi generated client configuration file ends with "</BODY></HTML>"
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Other (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.8.0
Assignee: Samuel Mannehed
URL:
Keywords: derfian_tester, prosaic
Depends on:
Blocks:
 
Reported: 2015-11-04 14:12 CET by Karl Mikaelsson
Modified: 2017-03-20 16:54 CET (History)
2 users (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Comment 2 Samuel Mannehed cendio 2016-12-07 12:37:49 CET 
Fixed by r31939. I have verified that the generated client configuration file does no longer contain these tags and that it works as intended.

Using cgitest.html I verified different configurations as well. Lastly I have also verified that the login, redirection, client verifier, and traceback pages works as expected.
Comment 5 Samuel Mannehed cendio 2016-12-07 16:23:33 CET 
Committed a few minor coding style changes, but this is ready for testing now.
Comment 7 Karl Mikaelsson cendio 2016-12-08 13:22:42 CET 
Code review: changes looks fine - setting titles this way is easier to follow than earlier approach.

Function test: generated HTML code has matching <html><body>, </body></html> tags, generated .tlclient does not.

Great!
Note You need to log in before you can comment on or make changes to this bug.