Bug 5676 - tl-show-licences should not change any state if manually executed.
Summary: tl-show-licences should not change any state if manually executed.
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: License system (show other bugs)
Version: 4.4.0
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.16.0
Assignee: Pierre Ossman
URL:
Keywords: adaha_tester, relnotes
Depends on:
Blocks:
 
Reported: 2015-10-16 14:41 CEST by Henrik Andersson
Modified: 2023-12-13 14:39 CET (History)
3 users (show)

See Also:
Acceptance Criteria:
MUST: * Tools/services that only want to check the license count should never send a license warning email SHOULD: * The license warning email should only be sent from a single place, to avoid accidental duplications

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Henrik Andersson cendio 2015-10-16 14:41:52 CEST 
tl-show-licenses is a reporting tool but it shares code path with vsmserver which tries to send a message to administrator if license usage is overused and rotate the usage log.
Comment 1 Peter Åstrand cendio 2015-10-20 10:21:16 CEST 
According to Karl, this is easy to fix.
Comment 2 Pierre Ossman cendio 2023-10-26 15:57:58 CEST 
Doing this now, since the email sending is tied up into the asyncore/asyncio switch in bug 7636.
Comment 4 Pierre Ossman cendio 2023-10-27 10:23:01 CEST 
This has now been fixed. Sending emails is now an explicit action, and it is only done from the vsmserver service.
Comment 5 Adam Halim cendio 2023-11-01 12:02:29 CET 
> MUST:
>   Tools/services that only want to check the license count should never send a >license warning email
Running tl-show-licenses does not send a mail anymore. ✓

> SHOULD:
>   The license warning email should only be sent from a single place, to avoid >accidental duplications
Verified that mail is only sent explicitly from vsmserver. ✓

Looks good, closing.
Note You need to log in before you can comment on or make changes to this bug.