Bug 5631 - vsmserver tracebacks on invalid/corrupted session database
Summary: vsmserver tracebacks on invalid/corrupted session database
Status: NEW
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: VSM Server (show other bugs)
Version: 4.1.0
Hardware: PC Unknown
: P2 Normal
Target Milestone: LowPrio
Assignee: Henrik Andersson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-09-08 09:25 CEST by Karl Mikaelsson
Modified: 2021-09-21 12:54 CEST (History)
2 users (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Karl Mikaelsson cendio 2015-09-08 09:25:51 CEST 
> 2015-09-07 14:14:33 INFO vsmserver: VSM Server version 4.1.0 build 3996 started
> 2015-09-07 14:14:33 INFO vsmserver.license: Updating license data from disk to memory
> 2015-09-07 14:14:33 INFO vsmserver.license: License summary: 10 concurrent users. Hard limit of 11 concurrent users. 
> Traceback (most recent call last):
>   File "/opt/thinlinc/sbin/vsmserver", line 22, in <module>
>     VSMServer ( sys . argv )
>   File "/opt/thinlinc/modules/thinlinc/vsm/vsmserver.py", line 137, in __init__
>     self . sessionstore = SessionStore ( self )
>   File "/opt/thinlinc/modules/thinlinc/vsm/sessionstore.py", line 87, in __init__
>     self . _load_sessions ( )
>   File "/opt/thinlinc/modules/thinlinc/vsm/sessionstore.py", line 188, in _load_sessions
>     self . sessions = cPickle . load ( open ( self . persistent_session_store ) )
> ValueError: insecure string pickle

This particular case was triggered by a failed session database write (no space left on device).

We should have some error checking here and tell the administrator exactly what's going on, how to work around it and what it means.
Comment 5 Pierre Ossman cendio 2021-04-13 16:47:39 CEST 
Note that we do have some error handling for bad files, but apparently not for everything.

Also see bug 7660.
Note You need to log in before you can comment on or make changes to this bug.