Bug 5630 - encrypt-vnc-pw is needlessly complex (replace with Python DES?)
Summary: encrypt-vnc-pw is needlessly complex (replace with Python DES?)
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: VSM Agent (show other bugs)
Version: pre-1.0
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.11.0
Assignee: Alex Tanskanen
URL:
Keywords: ossman_tester, prosaic
Depends on:
Blocks:
 
Reported: 2015-09-07 14:43 CEST by Pierre Ossman
Modified: 2019-10-07 10:56 CEST (History)
2 users (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Pierre Ossman cendio 2015-09-07 14:43:59 CEST 
Right now we call out to a subprocess called 'encrypt-vnc-pw' to perform the VNC password obfuscation from VSM agent. This makes things needlessly complex as we have to set up and wait for that subprocess. It would be much better if we could do the obfuscation directly from Python.

The command does a single DES round, so the performance difference should be negligible.
Comment 3 Pierre Ossman cendio 2019-10-07 10:56:44 CEST 
Verified on RHEL 8 using a Fedora 30 client and Webaccess. Tested shadowing and normal logins. Also tested using a session from 4.10.1 as well as a session created with the new code.
Note You need to log in before you can comment on or make changes to this bug.