Bug 5603 - Visually indicate uncought javascript errors in the HTML5 client
Summary: Visually indicate uncought javascript errors in the HTML5 client
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Web Access (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.5.0
Assignee: Samuel Mannehed
URL:
Keywords: ossman_tester, prosaic
Depends on:
Blocks:
 
Reported: 2015-08-10 17:01 CEST by Samuel Mannehed
Modified: 2015-09-25 13:57 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Samuel Mannehed cendio 2015-08-10 17:01:51 CEST 
For example, if the HTML5 client doesn't start and there is an error in the browser console the user will still only see "The HTML5 client is loading..." while it in fact isn't.

We should visually indicate that something went wrong in these cases.
Comment 3 Pierre Ossman cendio 2015-09-21 14:15:51 CEST 
Doesn't work if the crash is after UI.connect() has been called.
Comment 5 Samuel Mannehed cendio 2015-09-22 14:40:13 CEST 
Fixed now.
Comment 7 Pierre Ossman cendio 2015-09-23 13:33:17 CEST 
Doesn't work properly when in a handler for incoming data. Managed to provoke this crash:

recv_message, caught exception: 
    name: ReferenceError
    message: fooo is not defined
UI.updateState@https://10.47.1.240:300/include/ui.js:716:1
RFB.prototype._updateState@https://10.47.1.240:300/include/rfb.js:544:17
RFB.prototype._negotiate_std_vnc_auth@https://10.47.1.240:300/include/rfb.js:759:17
RFB.prototype._negotiate_authentication@https://10.47.1.240:300/include/rfb.js:870:1
RFB.prototype._init_msg@https://10.47.1.240:300/include/rfb.js:1031:1
RFB.prototype._negotiate_security@https://10.47.1.240:300/include/rfb.js:731:20
RFB.prototype._init_msg@https://10.47.1.240:300/include/rfb.js:1028:1
RFB.prototype._handle_message@https://10.47.1.240:300/include/rfb.js:580:21
Websock.prototype._recv_message@https://10.47.1.240:300/include/websock.js:344:21
Comment 8 Pierre Ossman cendio 2015-09-23 13:34:17 CEST 
It is also might need some more layout improvements. You can't clearly tell what's the error message and what's the background behind it.
Comment 9 Pierre Ossman cendio 2015-09-23 13:37:22 CEST 
The error message is also not seen when the crash happens with the canvas visible.
Comment 10 Pierre Ossman cendio 2015-09-23 13:42:15 CEST 
A normal terminated session now also results in the message "Failed to connect.".
Comment 14 Samuel Mannehed cendio 2015-09-23 18:03:15 CEST 
r30842 fixes comment #7
r30845 fixes comment #8 and comment #9
r30846 fixes comment #10
Comment 15 Pierre Ossman cendio 2015-09-25 13:51:43 CEST 
Everything seems to work fine now.
Note You need to log in before you can comment on or make changes to this bug.