Gnome 3.16 has started using the symbolic version of application icons for display on the top bar. We should include such as well so that we have the same look as the included applications.
Information about symbolic icons: https://github.com/GNOME/gnome-icon-theme-symbolic
It's not just the client that has icons. tl-setup and such as it as well.
All done. Also did some cleanups. Tester needs to verify: - Installed application/mime-type - Installed normal PNG files for sizes 16/24/48 - Installed symbolic PNG files for sizes 16/24/48 - Installed normal SVG - Installed symbolic SVG - That rpm -qf works on all above files (%ghost check) - Cleanup on uninstall This needs to be done for: - tlclient - tlclient's mime type - tl-setup - tlwebadm - tlwebaccess And also of course check that gnome 3.16+ shows the symbolic icon in the top bar. Note that only tlclient and tl-setup can be tested for this.
(In reply to comment #3) > All done. Also did some cleanups. Tester needs to verify: > > - Installed application/mime-type Verified that application-vnd.cendio.thinlinc.clientconf mime types are installed. > - Installed normal PNG files for sizes 16/24/48 > - Installed symbolic PNG files for sizes 16/24/48 > - Installed normal SVG > - Installed symbolic SVG > Verified that each icon is installed of different formats specified above. 4 normal and 4 symbolic. > - That rpm -qf works on all above files (%ghost check) > Verified that all files are owned by ThinLinc packages: find /usr/share/icons/ -name *thinlinc* | xargs rpm -qf However there are some files that is not owned which is probably created by xdg tools. .../16x16/mimetypes/gnome-mime-application-vnd.cendio.thinlinc.clientconf.png .../24x24/mimetypes/gnome-mime-application-vnd.cendio.thinlinc.clientconf.png .../48x48/mimetypes/gnome-mime-application-vnd.cendio.thinlinc.clientconf.png > - Cleanup on uninstall > Verified that uninstallation of server and client removes the file. The files mentioned above created by xdg tools are also removed. > This needs to be done for: > > - tlclient > - tlclient's mime type > - tl-setup > - tlwebadm > - tlwebaccess > > And also of course check that gnome 3.16+ shows the symbolic icon in the top > bar. Note that only tlclient and tl-setup can be tested for this. Looks good...
(In reply to comment #4) > However there are some files that is not owned which is probably created by xdg > tools. > > .../16x16/mimetypes/gnome-mime-application-vnd.cendio.thinlinc.clientconf.png > .../24x24/mimetypes/gnome-mime-application-vnd.cendio.thinlinc.clientconf.png > .../48x48/mimetypes/gnome-mime-application-vnd.cendio.thinlinc.clientconf.png > > > > - Cleanup on uninstall > > > > Verified that uninstallation of server and client removes the file. The files > mentioned above created by xdg tools are also removed. > We should probably add ghost entries for those gnome-mime... files.
(In reply to comment #5) > > We should probably add ghost entries for those gnome-mime... files. Fixed in r30660. One might consider also adding those compatibility icons for the symbolic icons and the SVGs as well. But probably not worth the effort given that it is for legacy support.
(In reply to comment #6) > (In reply to comment #5) > > > > We should probably add ghost entries for those gnome-mime... files. > > Fixed in r30660. > > One might consider also adding those compatibility icons for the symbolic icons > and the SVGs as well. But probably not worth the effort given that it is for > legacy support. Looks good.
