Bug 5554 - vsmagent and vsmserver doesn't restart after logrotate on SLES 12
Summary: vsmagent and vsmserver doesn't restart after logrotate on SLES 12
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: VSM Agent (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.4.0
Assignee: Pierre Ossman
URL:
Keywords: samuel_tester
Depends on:
Blocks:
 
Reported: 2015-05-26 15:22 CEST by Samuel Mannehed
Modified: 2015-05-27 13:29 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Samuel Mannehed cendio 2015-05-26 15:22:06 CEST 
These two files uses "service <service> condrestart" to restart vsmagent and vsmserver after logrotate:

/etc/logrotate.d/thinlinc-vsm-server
/etc/logrotate.d/thinlinc-vsm-agent

This doesn't work on (at least) SLES 12:

# /opt/thinlinc/libexec/service vsmagent condrestart
Usage: /sbin/service vsmagent {start|stop|reload|restart|try-restart|force-reload|status}

This has the effect that the old logfiles continue being used until the machine is restarted or until the services are properly restarted.
Comment 1 Pierre Ossman cendio 2015-05-26 15:58:38 CEST 
Apparently "condrestart" is a Red Hat:ism. The action specified by LSB is "try-restart", which is also included in the usage text on SLES 12.
Comment 2 Pierre Ossman cendio 2015-05-26 16:11:29 CEST 
Fixed in r30337.

Should be tested on all distributions to check that there isn't a problem with "try-restart".
Comment 3 Samuel Mannehed cendio 2015-05-27 10:09:03 CEST 
Tested and verified to work with rc3 on SLES 12 and RHEL 7. I will test on Ubuntu 14.04 before closing this.
Comment 4 Samuel Mannehed cendio 2015-05-27 13:29:33 CEST 
It's working well with rc3 on Ubuntu 14.04 as well and nothing seem to have broken due to the changes. Closing.
Note You need to log in before you can comment on or make changes to this bug.