Bug 5550 - Corresponding keyrelease isn't always sent when triggering keyrepeat
Summary: Corresponding keyrelease isn't always sent when triggering keyrepeat
Status: NEW
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: VNC (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: MediumPrio
Assignee: Pierre Ossman
URL:
Keywords:
Depends on:
Blocks: keyboard
  Show dependency tree / graph
 
Reported: 2015-05-25 16:11 CEST by Samuel Mannehed
Modified: 2021-09-15 17:05 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Samuel Mannehed cendio 2015-05-25 16:11:47 CEST 
Do the following:

* hold the 7 key and let the keyrepeat trigger
* while holding 7, tap Shift, release shift before letting go of 7

The client sends the following sequence of key events:

keypress: 7
keypress: 7
keypress: Shift_L
keypress: /
keyrelease: Shift_L
keypress: 7
keyrelease: 7

As we can see, the server never gets a release for /. Now imagine a server and a client with different keyboard layouts, this will results in / being stuck.
Comment 1 Pierre Ossman cendio 2021-09-15 17:05:48 CEST 
This is partially worked around in the server now, provided the client provides the physical key as well. The server needs to be at least 4.10.0, as does the client.

Still, we want to fix this in the client as well in case they connect to an old server. It's unclear if Web Access has the same issue, but if it does it should be fixed as browsers don't always provide physical key info.
Note You need to log in before you can comment on or make changes to this bug.