Bug 5530 - more logging on session shutdown reason
Summary: more logging on session shutdown reason
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: VSM Agent (show other bugs)
Version: pre-1.0
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.5.0
Assignee: Pierre Ossman
URL:
Keywords: hean01_tester, prosaic
Depends on:
Blocks:
 
Reported: 2015-05-13 13:23 CEST by Pierre Ossman
Modified: 2015-09-25 14:01 CEST (History)
2 users (show)

See Also:
Acceptance Criteria:


Attachments

Description Pierre Ossman cendio 2015-05-13 13:23:08 CEST
Right now we have little to no logging from Xvnc and tl-xinit when a session ends. It would be nice if they were at least verbose enough to see if we are terminating because of a crash, an external signal, logout, etc.
Comment 1 Pierre Ossman cendio 2015-05-13 13:25:04 CEST
For reference, Xorg finishes its log output with:

> (EE) Server terminated successfully (0). Closing log file.
Comment 2 Pierre Ossman cendio 2015-05-19 10:42:15 CEST
tl-run-profile might also need some more logging.
Comment 3 Pierre Ossman cendio 2015-09-01 13:31:48 CEST
(In reply to comment #1)
> For reference, Xorg finishes its log output with:
> 
> > (EE) Server terminated successfully (0). Closing log file.

This isn't really true anymore as modern distributions have also switched over to letting Xorg log to stderr. At that point there is no final output when it terminates.

Might be better to handle this from tl-xinit.
Comment 7 Pierre Ossman cendio 2015-09-01 14:18:39 CEST
All done.

Tester should check:

 - Final log line from tl-xinit
 - Exit code from profile command
 - That tl-xinit logs whenever the client or X server exits. This can be a normal exit, or a signal. Note that Xvnc grabs many signals and cleanly terminates.
 - That tl-xinit logs when it is asked to terminate via a signal (i.e. kill session).
Comment 8 Henrik Andersson cendio 2015-09-02 10:51:31 CEST
(In reply to comment #7)
> All done.
> 
> Tester should check:
> 
>  - Final log line from tl-xinit
>  - Exit code from profile command
>  - That tl-xinit logs whenever the client or X server exits. This can be a
> normal exit, or a signal. Note that Xvnc grabs many signals and cleanly
> terminates.
>  - That tl-xinit logs when it is asked to terminate via a signal (i.e. kill
> session).

Verified commits and the above test cases using build 4868.

No problems found.

Note You need to log in before you can comment on or make changes to this bug.