Bug 5506 - epiphany always shows touch controls in Web Access (bad touch detection)
Summary: epiphany always shows touch controls in Web Access (bad touch detection)
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Web Access (show other bugs)
Target Milestone: 4.15.0
Assignee: Samuel Mannehed
Keywords: prosaic, samuel_tester
Depends on:
Reported: 2015-04-24 13:08 CEST by Pierre Ossman
Modified: 2023-05-17 15:07 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:


Description Pierre Ossman cendio 2015-04-24 13:08:07 CEST Comment hidden (obsolete)
Comment 1 Samuel Mannehed cendio 2016-10-18 14:58:36 CEST Comment hidden (obsolete)
Comment 2 Samuel Mannehed cendio 2018-05-14 12:33:50 CEST
I tested eudemo's WebAccess in epiphany on Fedora 28 today. Can't see any keyboard or mouse problems. No certificate complaints either, but eudemo has a proper cert.

The only remaining problem I can see is that I get the touch controls without having a touch screen.
Comment 3 Samuel Mannehed cendio 2023-05-17 13:54:32 CEST
This was resolved in commit r39346 as part of bug 7908. The way we detect touch has been reworked and things appear to be more reliable here. The mobile-only on screen keyboard button no longer incorrectly show on Epiphany when used without a touch screen.

I tested Epiphany 43.1 on Fedora 37.
Comment 4 Samuel Mannehed cendio 2023-05-17 15:04:14 CEST
The new touch detection method no longer relies on JavaScript, but instead uses @media queries in CSS to check if the device has hover capabilities. This is built on the assumption that touch devices cannot hover. More details on this can be found in 
bug 8024 comment 6 and 7.

The new method was tested as part of bug 7908 on iPadOS, Android, Windows (no touch), Windows (touch) and macOS (see bug 7908 comment 535 and following comments):

 * The virtual keyboard button appears on devices with a touch screen
 * The virtual keyboard button does not appear on devices without a touch screen

Apart from determining whether the virtual keyboard button should be shown or not, the new touch detection method is also used to determine if we should show :hover styles on buttons and similar.
Comment 5 Samuel Mannehed cendio 2023-05-17 15:07:28 CEST
Note that, while resolving some issues, the new method introduces at least one new problem:

Keyboard button has disappeared on mobile in the latest release

Note that the device in question in the upstream issue is a fairly uncommon “Microsoft Surface Duo”. We haven't seen issues with other devices yet.

Note You need to log in before you can comment on or make changes to this bug.