5506 – epiphany always shows touch controls in Web Access (bad touch detection)

Bug 5506 - epiphany always shows touch controls in Web Access (bad touch detection)

Summary: epiphany always shows touch controls in Web Access (bad touch detection)

Status:	CLOSED FIXED

Alias:	None

Product:	ThinLinc
Classification:	Unclassified
Component:	Web Access (show other bugs)
Version:	pre-1.0
Hardware:	PC Unknown

Importance:	P2 Normal
Target Milestone:	4.15.0
Assignee:	Samuel Mannehed

URL:
Keywords:	prosaic, samuel_tester

Depends on:
Blocks:

Reported:	2015-04-24 13:08 CEST by Pierre Ossman
Modified:	2023-05-17 15:07 CEST (History)
CC List:	1 user (show)

See Also:	8024
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Pierre Ossman cendio

2015-04-24 13:08:07 CEST Comment hidden (obsolete)

Gnome's default web browser, Epiphany, works very poorly with our HTML client. Some of the issue I've found:

 - I get error code 1006 for my test server. Certificate issues?

 - I get the touch controls (mouse button selector, etc.)

 - Mouse doesn't seem to work. Possibly because it is hoping for touch events.

 - Some keys don't work, e.g. Escape

Comment 1 Samuel Mannehed cendio

2016-10-18 14:58:36 CEST Comment hidden (obsolete)

(In reply to comment #0)
>- I get error code 1006 for my test server. Certificate issues?

Yep: I see this in the console: "WebSocket network error: Unacceptable TLS certificate"

>- I get the touch controls (mouse button selector, etc.)

Gnome doesn't seem to want to leave it up to the webpage to decide if the device is touch or not. Epiphany always acts like it's on a touch device.

>- Mouse doesn't seem to work. Possibly because it is hoping for touch events.

Correct, I did a quick test, and it works in noVNC after applying the changes proposed here https://github.com/kanaka/noVNC/pull/619

>- Some keys don't work, e.g. Escape

Worksforme

Comment 2 Samuel Mannehed cendio

2018-05-14 12:33:50 CEST

I tested eudemo's WebAccess in epiphany on Fedora 28 today. Can't see any keyboard or mouse problems. No certificate complaints either, but eudemo has a proper cert.

The only remaining problem I can see is that I get the touch controls without having a touch screen.

Comment 3 Samuel Mannehed cendio

2023-05-17 13:54:32 CEST

This was resolved in commit r39346 as part of bug 7908. The way we detect touch has been reworked and things appear to be more reliable here. The mobile-only on screen keyboard button no longer incorrectly show on Epiphany when used without a touch screen.

I tested Epiphany 43.1 on Fedora 37.

Comment 4 Samuel Mannehed cendio

2023-05-17 15:04:14 CEST

The new touch detection method no longer relies on JavaScript, but instead uses @media queries in CSS to check if the device has hover capabilities. This is built on the assumption that touch devices cannot hover. More details on this can be found in 
bug 8024 comment 6 and 7.

The new method was tested as part of bug 7908 on iPadOS, Android, Windows (no touch), Windows (touch) and macOS (see bug 7908 comment 535 and following comments):

 * The virtual keyboard button appears on devices with a touch screen
 * The virtual keyboard button does not appear on devices without a touch screen

Apart from determining whether the virtual keyboard button should be shown or not, the new touch detection method is also used to determine if we should show :hover styles on buttons and similar.

Comment 5 Samuel Mannehed cendio

2023-05-17 15:07:28 CEST

Note that, while resolving some issues, the new method introduces at least one new problem:

Keyboard button has disappeared on mobile in the latest release
https://github.com/novnc/noVNC/issues/1757

Note that the device in question in the upstream issue is a fairly uncommon “Microsoft Surface Duo”. We haven't seen issues with other devices yet.

Note You need to log in before you can comment on or make changes to this bug.