We are doing some tweaks to TigerVNC in ThinLinc compared to the upstream version. This includes both re-brandning as well as some removed and added functionality. This has been tracked using our vendor drop system. In some cases, the "removed" upstream code has been commented out, such as in this case: case ID_INFO: if (fltk_escape(cc->connectionInfo(), buffer, sizeof(buffer)) < sizeof(buffer)) { // fl_message_title(_("VNC connection info")); + fl_message_title(_("ThinLinc connection info")); fl_message("%s", buffer); } This causes problems with the translations, since we are (now) including the preceding comment in the PO file. I'm suggesting that we use #ifdef conditionals instead, like this: case ID_INFO: if (fltk_escape(cc->connectionInfo(), buffer, sizeof(buffer)) < sizeof(buffer)) { #ifdef THINLINC_UPSTREAM fl_message_title(_("VNC connection info")); #else fl_message_title(_("ThinLinc connection info")); #endif // THINLINC_UPSTREAM fl_message("%s", buffer); }
Fixed in r30151. The tester should check that the diff against upstream is small and relevant: svn diff svn://svn.lkpg.cendio.se/vendor/tigervnc/current svn://svn.lkpg.cendio.se/trunk/ctc/vnc/tigervnc Basically, there should be no code changes which are not using the THINLINC_UPSTREAM conditional. Well, the exception is Makefiles etc, where #ifdef cannot be used.
Looks good. There were a few unnecessary diffs that was fixed in r30261.