Bug 5459 - Make vendordrop structure for websockify
Summary: Make vendordrop structure for websockify
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Web Access (show other bugs)
Target Milestone: 4.13.0
Assignee: Pierre Ossman
Keywords: linma_tester, nikle_tester, prosaic
Depends on:
Reported: 2015-03-05 11:46 CET by Samuel Mannehed
Modified: 2020-11-11 10:12 CET (History)
3 users (show)

See Also:
Acceptance Criteria:


Description Samuel Mannehed cendio 2015-03-05 11:46:48 CET

Websockify was removed from noVNC as of this commit. Currently we are running a quite old version of websocket.py which is the only file we use directly from the websockify project. We should set up so that we can do vendordrops from websockify just as we can with noVNC.

Comment 1 Samuel Mannehed cendio 2015-06-18 13:43:21 CEST
There are files living in both noVNC and websockify upstreams and there is no official consensus yet as to which project owns which files. Due to this we don't think we would benefit from adding infrastructure for this atm.
Comment 2 Samuel Mannehed cendio 2016-06-20 15:00:57 CEST
This isn't true anymore. The Websockify project is now the only proper upstream for these files.
Comment 4 Samuel Mannehed cendio 2016-06-20 15:42:58 CEST
NEVER MIND! /webaccess/noVNC/include/websock.js still lives in both the noVNC project and Websockify.. There seems to be more shared files in include.
Comment 5 Peter Åstrand cendio 2016-06-29 14:04:58 CEST
It is correct that there's some confusion over files such as websock.js. However, for websocket.py, it is clear that the websockify project is the only upstream. This file is no longer a part of the noVNC project. It is also still true that we are using this file, and that we are lagging behind. This is suboptimal. This means that we are not getting bug fixes or work such as Python 3 compatibility. See https://github.com/kanaka/websockify/commits/master/websockify/websocket.py .

Without a vendordrop structure, it's also difficult to see our own changes. r31509 does some changes that have not been pushed upstream, though.
Comment 12 Pierre Ossman cendio 2020-10-01 13:01:58 CEST
Should be all done.

Tester should try to torment the websocket/VNC connection and see if there is some way to get it to misbehave.
Comment 13 Niko Lehto cendio 2020-10-12 14:38:27 CEST
Tried to torment websock/VNC connection but did not find anything to remark about. Works good. (Firefox 81)
Comment 14 Pierre Ossman cendio 2020-10-23 15:01:37 CEST
There is this complaint in logs now:

> Oct 23 14:59:20 ubuntu1804 bash[10606]: /opt/thinlinc/modules/thinlinc/websocket.py:30: UserWarning: no 'numpy' module, HyBi protocol will be slower
> Oct 23 14:59:20 ubuntu1804 bash[10606]:   warnings.warn("no 'numpy' module, HyBi protocol will be slower")
Comment 16 Pierre Ossman cendio 2020-10-27 14:12:00 CET
No warning now. Rechecked on Ubuntu 18.04.
Comment 19 Pierre Ossman cendio 2020-11-06 14:38:20 CET
Oops. I only tested client disconnects, and not logouts. Should be fixed now.
Comment 20 Linn cendio 2020-11-11 10:12:08 CET
No longer crashes on log out.

Note You need to log in before you can comment on or make changes to this bug.