Bug 5447 - Restarting vsmserver may lead to all sessions being verified at the same time
Summary: Restarting vsmserver may lead to all sessions being verified at the same time
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: VSM Server (show other bugs)
Version: 4.3.0
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.4.0
Assignee: Karl Mikaelsson
URL:
Keywords: ossman_tester, prosaic
Depends on:
Blocks:
 
Reported: 2015-02-25 18:52 CET by Karl Mikaelsson
Modified: 2015-04-24 13:47 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Karl Mikaelsson cendio 2015-02-25 18:52:56 CET 
If vsmserver has been stopped for more than session_update_delay (10 minutes), vsmserver will try to verify all sessions _at once_ on startup. That's bad because it will consume a lot of server resources at once, instead of spreading the load evenly over a session_update_delay interval.

If we were to introduce a random delay from 0 to session_update_delay until vsmserver starts checking the session, we should spread out the session checks evenly in the 10 minute intervals (given enough sessions).
Comment 3 Karl Mikaelsson cendio 2015-03-04 10:23:41 CET 
Fixed in r30086.

Tester should make sure vsmserver doesn't choke on loading a session database that contains more than 1024 sessions which hasn't been verified in 10 minutes.
Comment 4 Karl Mikaelsson cendio 2015-03-04 10:32:45 CET 
(In reply to comment #3)
> Fixed in r30086.
> 
> Tester should make sure vsmserver doesn't choke on loading a session database
> that contains more than 1024 sessions which hasn't been verified in 10 minutes.

See also: bug 5458.
Comment 5 Pierre Ossman cendio 2015-04-24 13:47:21 CEST 
Tested using the associated script. Sessions were verified and removed fairly evenly over a ten minute period.
Note You need to log in before you can comment on or make changes to this bug.