> ====================================================================== > FAIL: Checks that we don't do sys.exit(1) from tl-setup, since that can > ---------------------------------------------------------------------- > Traceback (most recent call last): > File "/autotests/installedtree/test_installedfiles.py", line 491, in test_tlsetup_exit > self.assertFalse(self.does_exit_1(fn), "%s does unsafe sys.exit(1)" % fn) > AssertionError: /opt/thinlinc/modules/thinlinc/firewall.py does unsafe sys.exit(1) > > ------------------------------------------------------------------- The test seems to make sure that nothing in tl-setup does sys.exit(1), because that's how sudo signals errors and we don't want to trigger the sudo error handling if something else goes wrong in tl-setup.
Changes to autotests reverted in r29919. Updating the summary so we can re-introduce the autotest changes when this bug is done.
Code fixed in r30703 and autotest reenabled in r30704.
We have one "sys.exit(1)" in: tlmisc/modules/thinlinc/tlgtk/__init__.py And since tl-setup uses tlgtk I guess this should be fixed.
It is using exit code 1 to be consistent with Python's built in exception handler (which it is trying to emulate).
Verified commits and comments #3 and #4. Everything looks good. Closing.
