Bug 5412 - make *-zip targets doesn't really care what it includes in the zip files
Summary: make *-zip targets doesn't really care what it includes in the zip files
Status: CLOSED WONTFIX
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Build system (show other bugs)
Version: 4.3.0
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.15.0
Assignee: Bugzilla mail exporter
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2015-01-29 16:24 CET by Karl Mikaelsson
Modified: 2023-04-04 13:26 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Karl Mikaelsson cendio 2015-01-29 16:24:05 CET 
> # ./install-server: 
> The following packages will be installed:
>
> 	thinlinc-tlmisc-4.3.0post-4637.x86_64.rpm
> 	thinlinc-tlmisc-4.3.0post-4638.x86_64.rpm
> 	thinlinc-tlmisc-4.3.0post-4640.x86_64.rpm
> 	thinlinc-tlmisc-libs-4.3.0post-4637.x86_64.rpm
> 	thinlinc-tlmisc-libs-4.3.0post-4638.x86_64.rpm
> 	thinlinc-tlmisc-libs-4.3.0post-4640.x86_64.rpm
> 	thinlinc-tlmisc-libs32-4.3.0post-4637.i686.rpm
> 	thinlinc-tlmisc-libs32-4.3.0post-4638.i686.rpm
> 	thinlinc-tlmisc-libs32-4.3.0post-4640.i686.rpm
> 	thinlinc-vsm-4.3.0post-4637.x86_64.rpm
> 	thinlinc-vsm-4.3.0post-4638.x86_64.rpm
> 	thinlinc-vsm-4.3.0post-4640.x86_64.rpm
> 	thinlinc-vnc-server-4.3.0post-4640.x86_64.rpm
> 	thinlinc-rdesktop-4.3.0post-4637.x86_64.rpm
> 	thinlinc-rdesktop-4.3.0post-4638.x86_64.rpm
> 	thinlinc-rdesktop-4.3.0post-4640.x86_64.rpm
> 	thinlinc-tladm-4.3.0post-4637.x86_64.rpm
> 	thinlinc-tladm-4.3.0post-4638.x86_64.rpm
> 	thinlinc-tladm-4.3.0post-4640.x86_64.rpm
> 	thinlinc-tlprinter-4.3.0post-4640.noarch.rpm
> 	thinlinc-webaccess-4.3.0post-4640.noarch.rpm

To it's credit, yum actually managed to deal with it and figure out that only the latest version of each package should be installed. I haven't tried other platforms.

Investigating the cause of this led to these make rules in the top-level Makefile:

> # grep -A2 -B1 "find.*zip" Makefile 

> tl-$(VERSION)_$(BUILD)-server.zip: $(SERVER_BUNDLE)
> 	ln -s server-bundle $(SERVERBUNDLE_DIR)
> 	find $(SERVERBUNDLE_DIR)/ $(FIND_EXCLUDE_SVN_CMD) | cbrun i386 zip $@ -@
> 	rm $(SERVERBUNDLE_DIR)

> tl-$(VERSION)_$(BUILD)-clients.zip: $(CLIENT_BUNDLE)
> 	ln -s client-bundle $(CLIENTBUNDLE_DIR)
> 	find $(CLIENTBUNDLE_DIR)/ $(FIND_EXCLUDE_SVN_CMD) | cbrun i386 zip $@ -@
> 	rm $(CLIENTBUNDLE_DIR)
Comment 1 Pierre Ossman cendio 2023-04-04 13:26:32 CEST 
This doesn't seem to have any practical consequences, so wasn't really a problem. It's even less of a problem now as we have the same build number for all development builds, and hence don't get those duplicate package files.
Note You need to log in before you can comment on or make changes to this bug.