Bug 5361 - Add use of new comment field in license
Summary: Add use of new comment field in license
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: VSM Server (show other bugs)
Version: 4.2.0
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.4.0
Assignee: Henrik Andersson
URL:
Keywords: prosaic, samuel_tester
Depends on:
Blocks: 4773
  Show dependency treegraph
 
Reported: 2014-11-19 09:50 CET by Henrik Andersson
Modified: 2015-04-01 09:07 CEST (History)
2 users (show)

See Also:
Acceptance Criteria:


Attachments

Description Henrik Andersson cendio 2014-11-19 09:50:44 CET
The mail sent when licenses are expired should include the content of comment field.
Comment 1 Henrik Andersson cendio 2014-11-19 09:55:16 CET
There are also fields that is deprecated, city / location which needs to be handled the correct way eg. do not show them in mail as UNKNOWN, just hide the fields if unset.
Comment 2 Henrik Andersson cendio 2015-01-28 11:33:02 CET
Fixed in commit 29854.
Comment 3 Henrik Andersson cendio 2015-02-02 09:16:33 CET
(In reply to comment #2)
> Fixed in commit 29854.

Typos fixed in commit r29855
Comment 4 Henrik Andersson cendio 2015-02-03 13:57:49 CET
Verified that the mail contained a comment field and no city/location with UNKNOWN values.
Comment 5 Samuel Mannehed cendio 2015-03-31 10:00:32 CEST
The code looks good, and the email seems to be correct:

> Your ThinLinc cluster has the following license files:
> 
> * SUB12-00000467_30815f.zip:user-1-6266.license: 1 concurrent users. Hard limit > of 1 concurrent users. 
>     Customer: testaccount
>     License Number: 6266
>     
>     Comment: 

However, when creating licenses, the comment specified in roundup doesn't make it into the license file, reopening.
Comment 6 Henrik Andersson cendio 2015-03-31 11:09:59 CEST
(In reply to comment #5)
> The code looks good, and the email seems to be correct:
> 
> > Your ThinLinc cluster has the following license files:
> > 
> > * SUB12-00000467_30815f.zip:user-1-6266.license: 1 concurrent users. Hard limit > of 1 concurrent users. 
> >     Customer: testaccount
> >     License Number: 6266
> >     
> >     Comment: 
> 
> However, when creating licenses, the comment specified in roundup doesn't make
> it into the license file, reopening.

Bug in RoundUp, fixed in commit 30194.
Comment 7 Samuel Mannehed cendio 2015-04-01 09:07:56 CEST
Works perfectly now! Closing

Note You need to log in before you can comment on or make changes to this bug.