Bug 5337 - Set _NET_WM_PID property on X11 window
Summary: Set _NET_WM_PID property on X11 window
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Client (show other bugs)
Version: 4.2.0
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.4.0
Assignee: Henrik Andersson
URL:
Keywords: relnotes, samuel_tester
Depends on:
Blocks:
 
Reported: 2014-11-04 13:57 CET by Peter Åstrand
Modified: 2015-04-23 14:59 CEST (History)
3 users (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Peter Åstrand cendio 2014-11-04 13:57:19 CET 
We should set the _NET_WM_PID property on the tlclient and vncviewer windows. Without this property, the IGEL connection manager is not able to terminate our client upon suspend, as reported here:

http://lists.cendio.se/pipermail/thinlinc-technical/2014-October/000651.html
Comment 1 Peter Åstrand cendio 2014-11-11 11:27:48 CET 
http://www.fltk.org/str.php?L3150
Comment 2 Henrik Andersson cendio 2014-12-16 16:44:28 CET 
GTK+ uses XSetWMProperties() which sets WM_CLIENT_MACHINE and WM_LOCALE_NAME to proper values.
Comment 3 Henrik Andersson cendio 2014-12-17 15:28:33 CET 
Patched added to cenbuild in commit r29737.
Comment 4 Henrik Andersson cendio 2014-12-17 15:29:19 CET 
(In reply to comment #3)
> Patched added to cenbuild in commit r29737.

Tested and verified that adding the NET_VM_PID fixes the main issue with IGEL and suspend.
Comment 5 Henrik Andersson cendio 2015-01-12 09:03:10 CET 
Using long datatype for pid fixed in commit r29759
Comment 6 Pierre Ossman cendio 2015-04-20 14:02:33 CEST 
Committed upstream as r10710.
Comment 7 Samuel Mannehed cendio 2015-04-23 13:44:32 CEST 
Reproduced the problem with 4.3.0 on Igel UD3 and verified that it is fixed with build 4588.

$ xprop -name "ThinLinc Client" | grep _NET_WM_PID
_NET_WM_PID(CARDINAL) = 15221
Comment 8 Samuel Mannehed cendio 2015-04-23 14:59:19 CEST 
[samuel@samuel-80 ~]$ xprop -name "ThinLinc Client" | grep WM_CLIENT_MACHINE
WM_CLIENT_MACHINE(STRING) = "samuel-80"
[samuel@samuel-80 ~]$ xprop -name "ThinLinc Client" | grep WM_LOCALE_NAME
WM_LOCALE_NAME(STRING) = "en_GB.utf8"

Looks good.
Note You need to log in before you can comment on or make changes to this bug.