Bug 5335 - upgrade to FLTK 1.3.3
Summary: upgrade to FLTK 1.3.3
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Build system (show other bugs)
Version: pre-1.0
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.4.0
Assignee: Pierre Ossman
URL:
Keywords: hean01_tester, prosaic
Depends on:
Blocks:
 
Reported: 2014-11-04 09:49 CET by Pierre Ossman
Modified: 2015-04-24 07:26 CEST (History)
2 users (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Pierre Ossman cendio 2014-11-04 09:49:27 CET 
It was released yesterday and should contain all of our modifications. I.e. we can use it without any extra patches.
Comment 1 Pierre Ossman cendio 2014-11-19 13:38:42 CET 
Urgh. They've fiddled around with the CMake stuff quite a bit. Need to tweak our spec file to compensate.
Comment 2 Pierre Ossman cendio 2014-11-19 13:39:24 CET 
fltk-config is also gone for CMake-builds, so we need to change how tlclient is built.
Comment 3 Pierre Ossman cendio 2014-12-11 16:52:59 CET 
Upgrade in r29721. tlclient tweaked in r29722.

Need to check that all our features work as well. Waiting for a build.
Comment 4 Pierre Ossman cendio 2015-02-03 14:44:16 CET 
I've now tested our patches on Linux, Windows and OS X. Can't find any problems.
Comment 5 Henrik Andersson cendio 2015-04-14 15:35:53 CEST 
Tested all ui elements and logics, clipboard on Linux, Windows and OSX using client build 4723, everything works as expect except i stumble upon crashes in vncviewer on OSX platform.

Need to investigate that crash more if it related to this upgrade.
Comment 6 Henrik Andersson cendio 2015-04-15 09:36:24 CEST 
(In reply to comment #5)
> Need to investigate that crash more if it related to this upgrade.

The crash is not reproducible using 4.3.0 client.
Comment 7 Henrik Andersson cendio 2015-04-15 11:58:54 CEST 
(In reply to comment #6)
> (In reply to comment #5)
> > Need to investigate that crash more if it related to this upgrade.
> 
> The crash is not reproducible using 4.3.0 client.

It's fastest and most consequently reproducible while using gedit in the session and while selecting a text move mouse around over text. Each new selection will produce copy to clipboard which is transferred to the client.
Comment 8 Henrik Andersson cendio 2015-04-15 13:47:13 CEST 
(In reply to comment #7)
> (In reply to comment #6)
> > (In reply to comment #5)
> > > Need to investigate that crash more if it related to this upgrade.
> > 
> > The crash is not reproducible using 4.3.0 client.
> 
> It's fastest and most consequently reproducible while using gedit in the
> session and while selecting a text move mouse around over text. Each new
> selection will produce copy to clipboard which is transferred to the client.

The issue seems to only affect OSX build
Comment 9 Henrik Andersson cendio 2015-04-16 13:54:02 CEST 
I tested to reproduce the issue with build 4605 which is a version using fltk 1.3.3 but before the gcc upgrade. I succesfully reproduced the crash.
Comment 10 Pierre Ossman cendio 2015-04-20 14:11:37 CEST 
Poor buffer management in the OS X clipboard code that lead to a buffer overflow. Fixed upstream in r10709, and locally in r30253.
Comment 11 Henrik Andersson cendio 2015-04-24 07:24:27 CEST 
(In reply to comment #10)
> Poor buffer management in the OS X clipboard code that lead to a buffer
> overflow. Fixed upstream in r10709, and locally in r30253.

Verified using build 4734, can't reproduce the crash anymore.
Comment 12 Henrik Andersson cendio 2015-04-24 07:26:52 CEST 
As of testing reported on comment #5 and some minor retesting with the latest build everything seems good.

Closing.
Note You need to log in before you can comment on or make changes to this bug.