Bug 5300 - investigate valgrind warnings for OpenSSH
Summary: investigate valgrind warnings for OpenSSH
Status: NEW
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Client (show other bugs)
Version: pre-1.0
Hardware: PC Unknown
: P2 Normal
Target Milestone: MediumPrio
Assignee: Pierre Ossman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-14 16:51 CEST by Pierre Ossman
Modified: 2018-03-19 17:14 CET (History)
2 users (show)

See Also:
Acceptance Criteria:


Attachments

Description Pierre Ossman cendio 2014-10-14 16:51:03 CEST
We get ridiculous amounts of warnings about use of uninitialised data when we run OpenSSH through valgrind. We need to check if this is harmless, and hopefully find a way to silence it without a massive performance hit.
Comment 1 Pierre Ossman cendio 2014-10-21 10:36:45 CEST
Retest after upgrade of OpenSSH and see if the problem remains. Re-evaluate priority if it's still an issue.
Comment 2 Pierre Ossman cendio 2015-06-16 10:31:22 CEST
Still an issue even after upgrade.
Comment 3 Karl Mikaelsson cendio 2015-09-01 14:27:06 CEST
From the OpenSSH 7.1 changelog:

> * Fix a number of memory faults (double-free, free of uninitialised
>   memory, etc) in ssh(1) and ssh-keygen(1). Reported by Mateusz
>   Kocielski.
Comment 4 Peter Åstrand cendio 2015-10-28 13:51:51 CET
With 4.5.0rc1 it's better but still a lot of warnings:

4.4.0:

[astrand@scilla ~]$ egrep '== [0-9A-Za-z]' .thinlinc/tlclient.log   | grep " ssh" | wc
   1105   11934  101197

4.5.0rc1:

[astrand@scilla ~]$ egrep '== [0-9A-Za-z]' .thinlinc/tlclient.log   | grep " ssh" | wc
    953   10389   89382

Was running:

valgrind --trace-children=yes --leak-check=full --suppressions=supp  /opt/thinlinc/lib/tlclient/tlclient.bin dhcp-254-194 -u admin -p xxx
Comment 5 Samuel Mannehed cendio 2018-03-19 17:01:30 CET
With thinlinc 4.9.0 I got 477 errors from valgrind that said:

"Conditional jump or move depends on uninitialised value(s)"

Added a suppression for this for bug 2723.
Comment 6 Samuel Mannehed cendio 2018-03-19 17:05:14 CET
With thinlinc 4.9.0 I got 99 errors from valgrind that said:

"Use of uninitialised value of size 8"

Added a suppression for this for bug 2723.
Comment 7 Samuel Mannehed cendio 2018-03-19 17:14:03 CET
With thinlinc 4.9.0 I got 6 errors from valgrind that said:

"Syscall param write(buf) points to uninitialsied byte(s)"

4 errors that said:

"Syscall param write(count) points to uninitialsied byte(s)"

Added suppressions for these for bug 2723.

Note You need to log in before you can comment on or make changes to this bug.