Bug 5298 - NFS parsing leaks memory
Summary: NFS parsing leaks memory
Status: NEW
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Client (show other bugs)
Version: pre-1.0
Hardware: PC Unknown
: P2 Normal
Target Milestone: MediumPrio
Assignee: Pierre Ossman
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-10-14 16:47 CEST by Pierre Ossman
Modified: 2016-05-12 13:11 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:


Attachments

Description Pierre Ossman cendio 2014-10-14 16:47:54 CEST
From bug 2723:

* parse_nfs_export_option() doesn't properly free the members of the list.
Callers might also be effected:

> ==10068== 73 (16 direct, 57 indirect) bytes in 1 blocks are definitely lost in loss record 298 of 585
> ==10068==    at 0x4A0645D: malloc (in /usr/lib64/valgrind/vgpreload_memcheck-amd64-linux.so)
> ==10068==    by 0x58333C: operator new(unsigned long) (in /opt/thinlinc/lib/tlclient/tlclient.bin)
> ==10068==    by 0x432873: parse_nfs_export_option(std::string, std::vector<Exportdata*, std::allocator<Exportdata*> >&) (tlclient_util.cc:1442)
> ==10068==    by 0x42092A: Session::StartNFSServer() (tlclient_session.cc:2177)
> ==10068==    by 0x40FDEF: MainWindow::DoLogin(std::string, std::string, std::string, std::string, pkcs11_certificate const*, std::string const&, std::string, bool) (tlclient_mainwindow.cc:888)
> ==10068==    by 0x413343: MainWindow::TriggerLogin() (tlclient_mainwindow.cc:648)
> ==10068==    by 0x469642: Fl_Widget::do_callback(Fl_Widget*, void*) (in /opt/thinlinc/lib/tlclient/tlclient.bin)
> ==10068==    by 0x464EC4: Fl_Return_Button::handle(int) (in /opt/thinlinc/lib/tlclient/tlclient.bin)
> ==10068==    by 0x45801C: Fl_Group::handle(int) (in /opt/thinlinc/lib/tlclient/tlclient.bin)
> ==10068==    by 0x45801C: Fl_Group::handle(int) (in /opt/thinlinc/lib/tlclient/tlclient.bin)
> ==10068==    by 0x44E2F2: send(int, Fl_Widget*, Fl_Window*) (in /opt/thinlinc/lib/tlclient/tlclient.bin)
> ==10068==    by 0x44F07A: Fl::handle_(int, Fl_Window*) (in /opt/thinlinc/lib/tlclient/tlclient.bin)

Note You need to log in before you can comment on or make changes to this bug.