Bug 5206 - Scripts in /etc/profile.d don't need execute permissions
Summary: Scripts in /etc/profile.d don't need execute permissions
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Client (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.3.0
Assignee: Peter Åstrand
URL:
Keywords: prosaic, samuel_tester
Depends on:
Blocks:
 
Reported: 2014-07-02 08:08 CEST by Aaron Sowry
Modified: 2014-10-15 12:24 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Aaron Sowry cendio 2014-07-02 08:08:56 CEST 
They're sourced not executed, so the hashbang can probably go too.
Comment 1 Peter Åstrand cendio 2014-07-08 13:46:04 CEST 
The hashbang was only present in files owned by tlclient. Removed in 29183.

Wrt the executable bits, I'd say that they should go. CentOS/RHEL/Fedora typically does not use them. There was even a KDE bug to fix that: https://bugzilla.redhat.com/show_bug.cgi?id=571057. Ubuntu 14.04 has a profile.d directory, but no executable files.
Comment 2 Peter Åstrand cendio 2014-07-08 13:49:42 CEST 
(In reply to comment #1)

> Wrt the executable bits, I'd say that they should go. CentOS/RHEL/Fedora
> typically does not use them. There was even a KDE bug to fix that:
> https://bugzilla.redhat.com/show_bug.cgi?id=571057. Ubuntu 14.04 has a
> profile.d directory, but no executable files.

Fixed in 29184.
Comment 3 Samuel Mannehed cendio 2014-10-14 14:30:04 CEST 
After installation on ubuntu 14.04, build 4522:

cendio@ubuntu1404vm:~$ ls -lt /etc/profile.d/t*
-rwxr-xr-x 1 root root 1261 Oct 13 19:18 /etc/profile.d/thinlinc.csh
-rwxr-xr-x 1 root root  768 Oct 13 19:18 /etc/profile.d/thinlinc.sh
-rwxr-xr-x 1 root root  460 Oct 13 18:25 /etc/profile.d/tlclient.csh
-rwxr-xr-x 1 root root  301 Oct 13 18:25 /etc/profile.d/tlclient.sh
Comment 4 Peter Åstrand cendio 2014-10-14 14:34:24 CEST 
(In reply to comment #3)
> After installation on ubuntu 14.04, build 4522:
> 
> cendio@ubuntu1404vm:~$ ls -lt /etc/profile.d/t*
> -rwxr-xr-x 1 root root 1261 Oct 13 19:18 /etc/profile.d/thinlinc.csh
> -rwxr-xr-x 1 root root  768 Oct 13 19:18 /etc/profile.d/thinlinc.sh
> -rwxr-xr-x 1 root root  460 Oct 13 18:25 /etc/profile.d/tlclient.csh
> -rwxr-xr-x 1 root root  301 Oct 13 18:25 /etc/profile.d/tlclient.sh

r29503.
Comment 5 Samuel Mannehed cendio 2014-10-15 12:24:56 CEST 
(In reply to comment #4)
> r29503.

$ ls -lt /etc/profile.d/t*
-rw-r--r-- 1 root root 1261 Oct 14 19:19 /etc/profile.d/thinlinc.csh
-rw-r--r-- 1 root root  768 Oct 14 19:19 /etc/profile.d/thinlinc.sh
-rw-r--r-- 1 root root  460 Oct 14 18:25 /etc/profile.d/tlclient.csh
-rw-r--r-- 1 root root  301 Oct 14 18:25 /etc/profile.d/tlclient.sh

Looks good with build 4523.
Note You need to log in before you can comment on or make changes to this bug.