Bug 5159 - ignore empty $TLCOMMAND? (regression)
Summary: ignore empty $TLCOMMAND? (regression)
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Misc (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.3.0
Assignee: Karl Mikaelsson
URL:
Keywords: hean01_tester, prosaic
Depends on:
Blocks:
 
Reported: 2014-05-23 08:30 CEST by Pierre Ossman
Modified: 2014-10-06 16:13 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Pierre Ossman cendio 2014-05-23 08:30:00 CEST 
Bug 3249 and bug 5077 changed the behaviour of $TLCOMMAND so that an empty command is no longer treated the same as a non-existent one.

We might want to change back to the old behaviour of ignoring an empty command. Possibly with a warning...
Comment 1 Karl Mikaelsson cendio 2014-07-25 11:30:38 CEST 
Fixed in r29221.

Zero-length or whitespace-only $TLCOMMAND will be ignored and a warning message will be printed from both tl-select-profile and tl-run-profile.

I've decided to print warnings from both programs so we can be sure that there's something in the log if the user decides to quit from tl-select-profile. At the same time, tl-select-profile is optional so we need to have something in tl-run-profile as well.
Comment 2 Henrik Andersson cendio 2014-09-25 09:25:55 CEST 
Verified that information is logged and that logics isn't changed with and without TLCOMMAND both as empty or with command using ThinLinc build 4497.
Note You need to log in before you can comment on or make changes to this bug.