Bug 5126 - Non-ASCII usernames/passwords fails with rdesktop+CredSSP
Summary: Non-ASCII usernames/passwords fails with rdesktop+CredSSP
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: | rdesktop (deprecated) (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.3.0
Assignee: Henrik Andersson
URL:
Keywords: prosaic, samuel_tester
: 5236 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-05-07 10:41 CEST by Peter Åstrand
Modified: 2014-10-08 16:48 CEST (History)
2 users (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Peter Åstrand cendio 2014-05-07 10:41:32 CEST 
When using rdesktop with CredSSP against a Windows 2008 R2 server, it is not possible to send a non-ASCII username or password via RDP. This has been verified with:

thinlinc-rdesktop-4.1.0-3996.x86_64.rpm
thinlinc-rdesktop-4.1.1-4137.x86_64.rpm
thinlinc-rdesktop-4.2.0-4347.x86_64.rpm

It works without CredSSP (ie after kdestroy).
Comment 1 Henrik Andersson cendio 2014-05-20 09:41:48 CEST 
Fixed in upstream commit r1800.
Comment 2 Henrik Andersson cendio 2014-05-20 09:51:50 CEST 
Upstream commit r1801 make sure that all strings in cssp.c is written using rdp_out_unistr().

Tester need to test CredSSP SSO using password and smartcard.
Comment 3 Henrik Andersson cendio 2014-05-28 10:31:31 CEST 
Brought to ctc in vendor drop 29021.
Comment 4 Henrik Andersson cendio 2014-09-01 09:07:20 CEST 
*** Bug 5236 has been marked as a duplicate of this bug. ***
Comment 5 Henrik Andersson cendio 2014-09-01 09:41:40 CEST 
There are issues with rdp_out_unistr() that needs to be fixed.
Comment 6 Henrik Andersson cendio 2014-09-12 09:18:18 CEST 
(In reply to comment #5)
> There are issues with rdp_out_unistr() that needs to be fixed.

Added bug #5253 for rewrite of rdp_out_unistr() and it's usage.
Comment 7 Samuel Mannehed cendio 2014-10-08 16:48:27 CEST 
Works well. Tested using a username and password containing the swedish "å" against build 4506, with windows 2008 r2 server.
Note You need to log in before you can comment on or make changes to this bug.