Bug 5111 - Issues with fltk win32 clipboard patches
Summary: Issues with fltk win32 clipboard patches
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Build system (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.3.0
Assignee: Pierre Ossman
URL:
Keywords: astrand_tester, prosaic
Depends on:
Blocks: 5096
  Show dependency tree / graph
 
Reported: 2014-04-29 09:51 CEST by Henrik Andersson
Modified: 2014-10-13 11:11 CEST (History)
0 users

See Also:
Acceptance Criteria:

Attachments
Path which fix the correct behavior. (628 bytes, patch)
2014-04-29 11:30 CEST, Henrik Andersson 		Details | Diff
Fixes 2 identified problems with clipboard monitoring. (1016 bytes, patch)
2014-05-23 14:31 CEST, Henrik Andersson 		Details | Diff
Complete patch that fixes 3 problems with clipboard monitoring on windows platform. (2.07 KB, patch)
2014-05-28 11:34 CEST, Henrik Andersson 		Details | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Description Henrik Andersson cendio 2014-04-29 09:51:55 CEST 
The handling of WM_CHANGECBCHAIN is invalid, its up to the application to pass this message further to next window if it wasn't a message for self.

Then WM_CHANGECBCHAIN is handled it should always return 0, which is not the case, the code path ends up in DefWindowProcw() which give an undefined behaviour.
Comment 1 Henrik Andersson cendio 2014-04-29 11:30:50 CEST 
Created attachment 533 [details]
Path which fix the correct behavior.
Comment 2 Henrik Andersson cendio 2014-05-23 14:31:36 CEST 
Created attachment 546 [details]
Fixes 2 identified problems with clipboard monitoring.
Comment 3 Henrik Andersson cendio 2014-05-28 11:31:32 CEST 
There is also a third problem; Every window that is created is hooking up the clipboard monitoring, even if the fltk application didn't registered a clipboard notification handler. We shouldn't do that due to the flaky clipboard monitoring API.
Comment 4 Henrik Andersson cendio 2014-05-28 11:34:38 CEST 
Created attachment 549 [details]
Complete patch that fixes 3 problems with clipboard monitoring on windows platform.

Updated patch that fixes the three identified problems.
Comment 5 Henrik Andersson cendio 2014-05-28 13:30:14 CEST 
Patch commited to buildsystem in 29023.
Comment 6 Pierre Ossman cendio 2014-10-07 16:23:38 CEST 
This patch is incomplete. If you unregister all handlers it will fail to unregister from Windows as the untarget function always tries to find a new window to register.
Comment 7 Pierre Ossman cendio 2014-10-08 14:49:21 CEST 
Fixed in r29477 (and upstream). Not possible to test unfortunately as vncviewer doesn't stumble upon this bug.
Comment 8 Peter Åstrand cendio 2014-10-13 11:11:15 CEST 
(In reply to comment #7)
> Fixed in r29477 (and upstream). Not possible to test unfortunately as vncviewer
> doesn't stumble upon this bug.

Fair enough, closing then.
Note You need to log in before you can comment on or make changes to this bug.