Bug 5011 - Printer redirection seems to be broken with Windows 2012 R2
Summary: Printer redirection seems to be broken with Windows 2012 R2
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: | rdesktop (deprecated) (show other bugs)
Version: 4.1.1
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.2.0
Assignee: Henrik Andersson
URL:
Keywords: astrand_tester, prosaic
: 5134 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-03-05 10:54 CET by Henrik Andersson
Modified: 2014-05-15 08:43 CEST (History)
2 users (show)

See Also:
Acceptance Criteria:


Attachments
Patch to always register rdpsnd channel. (1.67 KB, patch)
2014-03-06 07:27 CET, Henrik Andersson
Details | Diff
Updated patch (2.23 KB, patch)
2014-03-06 11:29 CET, Henrik Andersson
Details | Diff

Description Henrik Andersson cendio 2014-03-05 10:54:43 CET
I couldn't even by specifying a printer driver get printer redirection to work.
Comment 1 Aaron Sowry cendio 2014-03-05 15:36:01 CET
This actually does work, provided:

1) Sound is enabled ("-r sound:local:alsa" or whatever)
2) A valid printer driver is specified for the exported printer ("printer:thinlocal="MS Publisher Imagesetter"" for example - see bug #4362)

Have tested briefly against Windows 2012 and 2012R2 - printing to thinlocal seems to work with thinlinc-rdesktop-4.1.1.
Comment 2 Henrik Andersson cendio 2014-03-06 07:09:04 CET
This is intended behavior for 2012 and specs has been updated:

http://social.msdn.microsoft.com/Forums/en-US/75024a3d-458f-4ed9-b55d-7852d0113bd7/rdpbcgrpdf-2-minors-problems-with-server-2012
Comment 3 Henrik Andersson cendio 2014-03-06 07:27:39 CET
Created attachment 511 [details]
Patch to always register rdpsnd channel.

This patch ensures that the rdpsnd and rdpdr static channels always are registered. Fixes both print and local drive redirection. Smartcard still have some problems, but i see communication over pcsc..
Comment 4 Henrik Andersson cendio 2014-03-06 11:29:53 CET
Created attachment 512 [details]
Updated patch

This is a patch the more properly handles a rdpsnd tunnel, it announces but only set capabilities to be alive if sound is enabled using -r sound argument.
Comment 5 Henrik Andersson cendio 2014-03-06 12:44:25 CET
(In reply to comment #4)
> Created an attachment (id=512) [details]
> Updated patch
> 
> This is a patch the more properly handles a rdpsnd tunnel, it announces but
> only set capabilities to be alive if sound is enabled using -r sound argument.

Commit upstream 1791.
Comment 6 Henrik Andersson cendio 2014-03-06 13:19:20 CET
(In reply to comment #5)
> (In reply to comment #4)
> > Created an attachment (id=512) [details] [details]
> > Updated patch
> > 
> > This is a patch the more properly handles a rdpsnd tunnel, it announces but
> > only set capabilities to be alive if sound is enabled using -r sound argument.
> 
> Commit upstream 1791.

Vendordrop in commit 28565.
Comment 7 Henrik Andersson cendio 2014-03-07 09:49:44 CET
(In reply to comment #5)
> (In reply to comment #4)
> > Created an attachment (id=512) [details] [details]
> > Updated patch
> > 
> > This is a patch the more properly handles a rdpsnd tunnel, it announces but
> > only set capabilities to be alive if sound is enabled using -r sound argument.
> 
> Commit upstream 1791.

Changes to audio and print/drive redirection has been tested against, Windows 2013r/2008r2/2012r2, Windows 8.1.
Comment 8 Peter Åstrand cendio 2014-05-05 13:57:02 CEST
Printer redirection tested on bug 4362. 

Sound now tested on 2003R2, 2008R2, and 2012R2, of course using https://www.youtube.com/watch?v=moSFlvxnbgk . 

For Windows 2012R2, I was not able to get sound working until I did "net start audiosrv" in a command shell as admin. But apparently, in the brave new Windows world, this is how it should be...
Comment 9 Henrik Andersson cendio 2014-05-13 16:10:19 CEST
*** Bug 5134 has been marked as a duplicate of this bug. ***
Comment 10 Henrik Andersson cendio 2014-05-13 16:11:25 CEST
(In reply to comment #9)
> *** Bug 5134 has been marked as a duplicate of this bug. ***

Upstream commit 1796 fixes introduced issue reported oon bug #5134.
Comment 11 Henrik Andersson cendio 2014-05-13 16:16:36 CEST
(In reply to comment #10)
> (In reply to comment #9)
> > *** Bug 5134 has been marked as a duplicate of this bug. ***
> 
> Upstream commit 1796 fixes introduced issue reported oon bug #5134.

Vendordrop brought to ctc in commit 28974.
Comment 12 Peter Åstrand cendio 2014-05-15 08:43:57 CEST
(In reply to comment #11)
> (In reply to comment #10)
> > (In reply to comment #9)
> > > *** Bug 5134 has been marked as a duplicate of this bug. ***
> > 
> > Upstream commit 1796 fixes introduced issue reported oon bug #5134.
> 
> Vendordrop brought to ctc in commit 28974.

recording works now (although not very good on my workstation, but that's another bug).

Note You need to log in before you can comment on or make changes to this bug.