At a customer site their tlwebaccess log contains a few tracebacks, all the same as the following one: 2014-02-04 11:16:35 INFO tlwebaccess[19186]: Connection from XX.XX.XX.XX, port 55121 2014-02-04 11:16:35 ERROR tlwebaccess[19187]: code 500, message Internal error on page '/main/' 2014-02-04 11:16:35 INFO tlwebaccess[19187]: "POST /main/ HTTP/1.1" 500 - 2014-02-04 11:16:35 ERROR tlwebaccess[19187]: ---------------------------------------- 2014-02-04 11:16:35 ERROR tlwebaccess[19187]: Traceback (most recent call last): 2014-02-04 11:16:35 ERROR tlwebaccess[19187]: File "/opt/thinlinc/sbin/tlwebaccess", line 272, in post_or_get 2014-02-04 11:16:35 ERROR tlwebaccess[19187]: O0ooOooooO , iIIii1ii11IIIiiI = getattr ( oO , action ) ( OOo00O0 , oooooOoo0ooo , O0ooOooooO ) 2014-02-04 11:16:35 ERROR tlwebaccess[19187]: File "/opt/thinlinc/modules/thinlinc/tlwebaccess/main.py", line 141, in do_POST 2014-02-04 11:16:35 ERROR tlwebaccess[19187]: self . _POST_METHODS . get ( page_name , self . error_404 ) ( query ) ) 2014-02-04 11:16:35 ERROR tlwebaccess[19187]: File "/opt/thinlinc/modules/thinlinc/tlwebaccess/main.py", line 223, in home 2014-02-04 11:16:35 ERROR tlwebaccess[19187]: o0O = [ int ( i1I1iI ) , int ( oo0OooOOo0 ) ] 2014-02-04 11:16:35 ERROR tlwebaccess[19187]: ValueError: invalid literal for int() with base 10: 'undefined'
Fixed in commit 29597.
(In reply to comment #1) > Fixed in commit 29597. Updated in r29598.
Reverted two previous commits in r29601 since the traceback problem was solved by commit 28723, done as part of bug 5030. don't submit the form if the attributes are undefined - r29602 better error handling on the login form - r29603
When does this occur? How do I test it?
As noted in comment #3 the traceback was fixed in ThinLinc 4.2 and the commits for this bug was not very related. I am changing the summary to better reflect this. Tester should review the changes and verify that the login isn't completed when innerWidth or innerHeight is undefined on the window.
And how do I make them undefined? The developer console doesn't seem to respect changes to such attributes. The original report doesn't state which browser was used.
I'm also not properly getting the error message about missing websockets support on IE 8 and IE 9. It shows up sometimes, but not always.
(In reply to comment #6) > And how do I make them undefined? The developer console doesn't seem to respect > changes to such attributes. The original report doesn't state which browser was > used. IE 8 doesn't have innerWidth or innerHeight for example. To submit the loginform you will probably have to enable the submit-button since it's disabled if the browser doesn't support websockets etc. In IE 8 you can open the Dev Tools and modify the html of the button. (In reply to comment #7) > I'm also not properly getting the error message about missing websockets > support on IE 8 and IE 9. It shows up sometimes, but not always. Fixed in r30280. Apparently old versions of IE doesn't create all objects until you have opened the Dev Tools: http://stackoverflow.com/questions/7742781/why-javascript-only-works-after-opening-developer-tools-in-ie-once
I get a proper error message on old versions of IE now. And the login button refuses to do anything when innerwidth/innerheigh are undefined.
