Bug 4986 - Push FLTK patches upstream
Summary: Push FLTK patches upstream
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Other (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.3.0
Assignee: Pierre Ossman
URL:
Keywords: astrand_tester, prosaic
Depends on:
Blocks:
 
Reported: 2014-02-11 16:36 CET by Pierre Ossman
Modified: 2014-10-06 15:54 CEST (History)
0 users

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Pierre Ossman cendio 2014-02-11 16:36:27 CET 
Continuation of bug 4830, which in turn was a continuation of bug 4786.
Comment 1 Pierre Ossman cendio 2014-06-10 16:11:01 CEST 
Time for a status check.

Committed:

Patch10: fltk-1.3.2-osx-10.4.patch
Patch21: fltk-1.3.2-shared.patch
Patch201: fltk-1.3.x-clipboard.patch
Patch202: fltk-1.3.x-clipboard-x11.patch
Patch204: fltk-1.3.x-clipboard-win32-fix.patch
Patch205: fltk-1.3.x-clipboard-win32.patch
Patch206: fltk-1.3.x-clipboard-osx.patch
Patch900: fltk-1.3.x-screen_num.patch
Patch1000: fltk-1.3.2-wmquit.patch
Patch1001: fltk-1.3.2-workarea.patch

Not committed:

Patch20: fltk-1.3.x-cmake-fpic.patch
Patch101: fltk-1.3.x-keyboard-x11.patch
Patch102: fltk-1.3.x-keyboard-win32.patch
Patch103: fltk-1.3.x-keyboard-osx.patch
Patch207: fltk-1.3.x-clipboard-win32-fix2.patch
Patch400: fltk-1.3.x-pixmap.patch
Patch401: fltk-1.3.x-cursor.patch
Patch700: fltk-1.3.0-modal.patch
Patch800: fltk-1.3.0-icons.patch
Patch901: fltk-1.3.x-multihead.patch
Comment 2 Pierre Ossman cendio 2014-06-10 16:24:15 CEST 
Committed:

Patch207: fltk-1.3.x-clipboard-win32-fix2.patch
Comment 3 Pierre Ossman cendio 2014-06-11 11:22:26 CEST 
Committed:

Patch901: fltk-1.3.x-multihead.patch
Comment 4 Pierre Ossman cendio 2014-06-11 16:17:24 CEST 
Committed:

Patch700: fltk-1.3.0-modal.patch

It exposed another issue in fltk though where menus will stack below full screen windows. Patch sent to the mailing list for review.
Comment 5 Pierre Ossman cendio 2014-06-12 15:30:02 CEST 
Committed:

Patch400: fltk-1.3.x-pixmap.patch
Comment 6 Pierre Ossman cendio 2014-06-16 13:42:04 CEST 
(In reply to comment #4)
> It exposed another issue in fltk though where menus will stack below full
> screen windows. Patch sent to the mailing list for review.

Committed.

Also committed:

Patch401: fltk-1.3.x-cursor.patch
Patch800: fltk-1.3.0-icons.patch
Comment 7 Pierre Ossman cendio 2014-06-16 13:43:58 CEST 
What's left now is:

Patch20: fltk-1.3.x-cmake-fpic.patch
Patch101: fltk-1.3.x-keyboard-x11.patch
Patch102: fltk-1.3.x-keyboard-win32.patch
Patch103: fltk-1.3.x-keyboard-osx.patch


The keyboard stuff will most likely get rewritten on bug 4677, so no need to push that. And the cmake fix needs further investigation as it is not clear why it is required. Might be something specific for us.
Comment 8 Pierre Ossman cendio 2014-09-11 15:23:11 CEST 
(In reply to comment #7)
> What's left now is:
> 
> Patch20: fltk-1.3.x-cmake-fpic.patch

I cannot find anything that breaks after I remove this patch, so let's get rid of it.
Comment 9 Pierre Ossman cendio 2014-09-15 13:33:03 CEST 
Done.
Comment 10 Peter Åstrand cendio 2014-09-22 16:30:22 CEST 
The comments for the later patches are a bit sparse, or non-existent, but it seems that everything is upstream.
Note You need to log in before you can comment on or make changes to this bug.