Bug 4941 - only show certificate download on mobile safari
Summary: only show certificate download on mobile safari
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Web Access (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.2.0
Assignee: Samuel Mannehed
URL:
Keywords: hean01_tester, prosaic
: 5029 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-12-12 13:07 CET by Pierre Ossman
Modified: 2014-04-02 08:59 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Pierre Ossman cendio 2013-12-12 13:07:02 CET 
This is a minimal effort version of bug 4863. Instead of going all out in magical detection, we'll just make the current display conditional on the browser being Safari on iOS.
Comment 1 Samuel Mannehed cendio 2014-02-10 16:01:08 CET 
Fixed revision 28392.
Comment 2 Samuel Mannehed cendio 2014-02-11 10:04:09 CET 
Fix updated in r28395.
Comment 3 Samuel Mannehed cendio 2014-02-14 12:34:56 CET 
Updated again in revision 28431.
Comment 4 Samuel Mannehed cendio 2014-03-06 09:47:16 CET 
Update for iOS's "web app" mode in r28562.
Comment 5 Henrik Andersson cendio 2014-03-18 14:31:46 CET 
Redirection page shows the link whatever browser i use.
Comment 6 Samuel Mannehed cendio 2014-03-18 14:38:48 CET 
(In reply to comment #5)
> Redirection page shows the link whatever browser i use.

fixed in revision 28655.
Comment 7 Henrik Andersson cendio 2014-03-19 12:22:07 CET 
(In reply to comment #6)
> (In reply to comment #5)
> > Redirection page shows the link whatever browser i use.
> 
> fixed in revision 28655.

Tested using build 4290 and everything works fine. Reviewed additional commit 28655 which looks good.
Comment 8 Henrik Andersson cendio 2014-03-20 07:34:52 CET 
*** Bug 5029 has been marked as a duplicate of this bug. ***
Comment 9 Henrik Andersson cendio 2014-03-20 07:36:24 CET 
Traceback in related code when 'User-Agent' header not exists in request.

See duplicate in previous comment for more details.
Comment 10 Henrik Andersson cendio 2014-03-20 08:02:41 CET 
The download link is shown on android browser.
Comment 11 Samuel Mannehed cendio 2014-03-25 16:10:16 CET 
(In reply to comment #9)
> Traceback in related code when 'User-Agent' header not exists in request.
> 
> See duplicate in previous comment for more details.

Fixed in revision 28712.

(In reply to comment #10)
> The download link is shown on android browser.

Fixed in revision 28711.
Comment 12 Henrik Andersson cendio 2014-03-26 11:07:22 CET 
(In reply to comment #11)
> (In reply to comment #9)
> > Traceback in related code when 'User-Agent' header not exists in request.
> > 
> > See duplicate in previous comment for more details.
> 
> Fixed in revision 28712.
> 
> (In reply to comment #10)
> > The download link is shown on android browser.
> 
> Fixed in revision 28711.

Verified with build 4303 tested using both android browser and iPad. Work as expected.
Note You need to log in before you can comment on or make changes to this bug.