Bug 4933 - Add dynamic string allocation to rdp_in_unistr()
Summary: Add dynamic string allocation to rdp_in_unistr()
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: | rdesktop (deprecated) (show other bugs)
Version: 4.1.1
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.2.0
Assignee: Henrik Andersson
URL:
Keywords: astrand_tester, prosaic
Depends on:
Blocks: 4920
  Show dependency tree / graph
 
Reported: 2013-12-06 10:06 CET by Henrik Andersson
Modified: 2014-05-05 14:52 CEST (History)
0 users

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Henrik Andersson cendio 2013-12-06 10:06:28 CET 
Change declaration as example below and use iconv to get the
correct string size then allocate the string.

rdp_in_unistr(STREAM s, int in_len, char **string, int *str_size)
Comment 1 Henrik Andersson cendio 2013-12-10 13:02:05 CET 
Commits r1773, r1774 adds the dynamic string allocation, commits r1775, r1776 cleans up related issues were used.
Comment 2 Henrik Andersson cendio 2013-12-12 13:27:12 CET 
Tester should test related functions using the rdp_in_unistr():

 - local printer rediretion
 - local drive redirection

 and server redirection in a farm.
Comment 3 Henrik Andersson cendio 2013-12-12 16:30:08 CET 
Vendordrop of upstream in commit 28197
Comment 4 Peter Åstrand cendio 2014-05-05 14:52:19 CEST 
(In reply to comment #2)
> Tester should test related functions using the rdp_in_unistr():
> 
>  - local printer rediretion
>  - local drive redirection
> 
>  and server redirection in a farm.

All this tested on other bugs.
Note You need to log in before you can comment on or make changes to this bug.