Bug 4929 - start using optimisation flags for new packages
Summary: start using optimisation flags for new packages
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Build system (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.4.0
Assignee: Pierre Ossman
URL:
Keywords: hean01_tester, prosaic
Depends on:
Blocks: 3304
  Show dependency tree / graph
 
Reported: 2013-12-04 11:00 CET by Pierre Ossman
Modified: 2015-04-17 12:13 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Pierre Ossman cendio 2013-12-04 11:00:32 CET 
This is a light version of bug 3304. Instead of going through every package and adjusting it, we'll update the template (and possibly documentation) and remind people to add proper flags when setting up new packages and updating old ones.
Comment 1 Pierre Ossman cendio 2015-02-05 17:31:05 CET 
Implemented by putting the flags in the %configure and %cmake macros. Also mentioned in the template in case neither autoconf or cmake are used.

Fixed in r29941 and r29942.
Comment 2 Peter Åstrand cendio 2015-02-20 10:30:15 CET 
cmake problem fixed in r30009.
Comment 3 Henrik Andersson cendio 2015-04-17 11:02:12 CEST 
Verified that cmake / configure macros works as expected building fltk and file have the expected optimization flags.
Comment 4 Henrik Andersson cendio 2015-04-17 12:12:39 CEST 
(In reply to comment #3)
> Verified that cmake / configure macros works as expected building fltk and file
> have the expected optimization flags.

file package was a bad test. Retested configure and CFLAGS using gettext package.

Looks good. Closing...
Note You need to log in before you can comment on or make changes to this bug.