Bug 4904 - ThinLincClientVerifier incorrectly claims client is installed on Linux
Summary: ThinLincClientVerifier incorrectly claims client is installed on Linux
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Client platforms (show other bugs)
Version: 4.1.0
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.2.0
Assignee: Peter Åstrand
URL:
Keywords: hean01_tester, relnotes
: 2850 4456 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-11-19 14:56 CET by Peter Åstrand
Modified: 2014-04-14 14:49 CEST (History)
3 users (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Peter Åstrand cendio 2013-11-19 14:56:29 CET 
On Ubuntu 12.04, the ThinLincClientVerifier says the client is OK, and enables the Continue button, even though the client is not installed.
Comment 1 Peter Åstrand cendio 2013-11-19 16:00:16 CET 
Our applet executes:

xdg-mime query default application/vnd.cendio.thinlinc.clientconf

However, xdg-mime returns no output and exits with return code zero, which we interpret as "success". I believe this is wrong. The documentation is not fully clear on the return code, but in case of success the name of the .desktop file should be returned. Thus, it should be safer to verify this. 

Also note that on least my system (CentOS 6), xdg-mime seems to be very unstable. Right now, it does not return anything when the client is installed, but after UNINSTALLING it, it returns the .desktop file...
Comment 2 Peter Åstrand cendio 2013-11-19 16:03:52 CET 
(In reply to comment #1)
 
> Also note that on least my system (CentOS 6), xdg-mime seems to be very
> unstable. Right now, it does not return anything when the client is installed,
> but after UNINSTALLING it, it returns the .desktop file...

Probably due to https://bugs.freedesktop.org/show_bug.cgi?id=31629. We should ship an updated version of xdg-mime. However, since the system version will have precedence, this will not change much in practice.
Comment 3 Peter Åstrand cendio 2013-11-19 16:35:56 CET 
(In reply to comment #2)
> (In reply to comment #1)
> 
> > Also note that on least my system (CentOS 6), xdg-mime seems to be very
> > unstable. Right now, it does not return anything when the client is installed,
> > but after UNINSTALLING it, it returns the .desktop file...
> 
> Probably due to https://bugs.freedesktop.org/show_bug.cgi?id=31629. We should
> ship an updated version of xdg-mime. However, since the system version will
> have precedence, this will not change much in practice.

New vendordrop in 28148.
Comment 4 Peter Åstrand cendio 2013-11-20 12:44:13 CET 
(In reply to comment #1)
> Our applet executes:
> 
> xdg-mime query default application/vnd.cendio.thinlinc.clientconf
> 
> However, xdg-mime returns no output and exits with return code zero, which we
> interpret as "success". I believe this is wrong. The documentation is not fully
> clear on the return code, but in case of success the name of the .desktop file
> should be returned. Thus, it should be safer to verify this. 

Fixed in 28156, we are checking for at least one line of output instead.
Comment 5 Peter Åstrand cendio 2013-12-02 12:42:12 CET 
*** Bug 2850 has been marked as a duplicate of this bug. ***
Comment 6 Peter Åstrand cendio 2013-12-02 12:43:10 CET 
*** Bug 4456 has been marked as a duplicate of this bug. ***
Comment 7 Henrik Andersson cendio 2014-04-14 14:49:05 CEST 
Verified functionality using build 4323, works as expected.
Note You need to log in before you can comment on or make changes to this bug.