Bug 4869 - crash with undefined method "setDesktopSize" when loading is slow
Summary: crash with undefined method "setDesktopSize" when loading is slow
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Web Access (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.4.0
Assignee: Samuel Mannehed
URL:
Keywords: ossman_tester, prosaic
Depends on:
Blocks:
 
Reported: 2013-10-24 13:54 CEST by Pierre Ossman
Modified: 2015-05-19 13:47 CEST (History)
0 users

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Pierre Ossman cendio 2013-10-24 13:54:16 CEST 
I get this with Chrome against a Solaris server:

Uncaught TypeError: Cannot call method 'setDesktopSize' of undefined ui.js:55
UI.onresize ui.js:55
(anonymous function) ui.js:24

Probably because we try to call setDesktopSize before we've set up the RFB object.
Comment 1 Pierre Ossman cendio 2013-10-25 15:45:24 CEST 
There might be more races in the code as I'm often getting problems against the Solaris server where everything just stops whilst loading the page.
Comment 2 Samuel Mannehed cendio 2015-03-05 11:02:31 CET 
The code has been improved (and the issue described in the description of this bug was fixed) in the rewrite done by upstream which was brought to ThinLinc in commit r29596.

Code review has been done and additional fixes to improve rubustness were commited upstream in 3b8ec46.
Comment 3 Samuel Mannehed cendio 2015-03-05 11:35:57 CET 
Fixed by vendordrop in r30096 and in commits r30097 and r30098.
Comment 4 Pierre Ossman cendio 2015-04-29 11:13:33 CEST 
Added some long delays to the web server, but I could not provoke any errors.
Comment 5 Samuel Mannehed cendio 2015-05-19 13:45:57 CEST 
One of the changes brought in by the vendordrop in r30096 causes backspace and non-US characters to stop working when using the on-screen keyboard on Android devices.

The issue was a silly typo which is fixed in r30324.
Note You need to log in before you can comment on or make changes to this bug.