Bug 4862 - HTML client mishandles login errors
Summary: HTML client mishandles login errors
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Web Access (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.2.0
Assignee: Samuel Mannehed
URL:
Keywords: hean01_tester, prosaic
Depends on:
Blocks:
 
Reported: 2013-10-23 13:49 CEST by Pierre Ossman
Modified: 2014-04-24 14:52 CEST (History)
2 users (show)

See Also:
Acceptance Criteria:

Attachments
Trying to connect to a stopped vsmserver (19.82 KB, image/png)
2014-04-10 13:35 CEST, Karl Mikaelsson 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Description Pierre Ossman cendio 2013-10-23 13:49:57 CEST 
The agent failed to create a session which left me with this page:

Failed to create new session: error=4
Password: [	]
	[Login]

Entering the password again brings me back to the original login page without any message.


Error messages should be the same as for the native client. And we should be brought to either a special error page, or back to the login page rather than this broken one.
Comment 1 Samuel Mannehed cendio 2014-02-14 15:07:30 CET 
Fixed in revision 28432.
Comment 2 Henrik Andersson cendio 2014-03-19 14:09:42 CET 
2014-03-19 14:08:39 ERROR tlwebaccess[2515]:   File "/opt/thinlinc/modules/thinlinc/tlwebaccess/main.py", line 147, in do_POST
2014-03-19 14:08:39 ERROR tlwebaccess[2515]:     self . _POST_METHODS . get ( page_name , self . error_404 ) ( query ) )
2014-03-19 14:08:39 ERROR tlwebaccess[2515]:   File "/opt/thinlinc/modules/thinlinc/tlwebaccess/main.py", line 297, in home
2014-03-19 14:08:39 ERROR tlwebaccess[2515]:     return self . check_authenticated ( o0O , Oo0O , II1III , O0o0 )
2014-03-19 14:08:39 ERROR tlwebaccess[2515]:   File "/opt/thinlinc/modules/thinlinc/tlwebaccess/main.py", line 338, in check_authenticated
2014-03-19 14:08:39 ERROR tlwebaccess[2515]:     return self . thinlinc_login ( username , ooOOoooooo , screen_size_array )
2014-03-19 14:08:39 ERROR tlwebaccess[2515]:   File "/opt/thinlinc/modules/thinlinc/tlwebaccess/main.py", line 468, in thinlinc_login
2014-03-19 14:08:39 ERROR tlwebaccess[2515]:     iiiI1I11i1 = "Failed to create new session with reason: %s" % vsmcommon . err_to_string [ OOOoo0OO ]
2014-03-19 14:08:39 ERROR tlwebaccess[2515]: AttributeError: 'module' object has no attribute 'err_to_string'
2014-03-19 14:08:39 ERROR tlwebaccess[2515]: ----------------------------------------
Comment 3 Samuel Mannehed cendio 2014-03-19 15:55:33 CET 
(In reply to comment #2)
> 2014-03-19 14:08:39 ERROR tlwebaccess[2515]:   File
> "/opt/thinlinc/modules/thinlinc/tlwebaccess/main.py", line 147, in do_POST
> 2014-03-19 14:08:39 ERROR tlwebaccess[2515]:     self . _POST_METHODS . get (
> page_name , self . error_404 ) ( query ) )
> 2014-03-19 14:08:39 ERROR tlwebaccess[2515]:   File
> "/opt/thinlinc/modules/thinlinc/tlwebaccess/main.py", line 297, in home
> 2014-03-19 14:08:39 ERROR tlwebaccess[2515]:     return self .
> check_authenticated ( o0O , Oo0O , II1III , O0o0 )
> 2014-03-19 14:08:39 ERROR tlwebaccess[2515]:   File
> "/opt/thinlinc/modules/thinlinc/tlwebaccess/main.py", line 338, in
> check_authenticated
> 2014-03-19 14:08:39 ERROR tlwebaccess[2515]:     return self . thinlinc_login (
> username , ooOOoooooo , screen_size_array )
> 2014-03-19 14:08:39 ERROR tlwebaccess[2515]:   File
> "/opt/thinlinc/modules/thinlinc/tlwebaccess/main.py", line 468, in
> thinlinc_login
> 2014-03-19 14:08:39 ERROR tlwebaccess[2515]:     iiiI1I11i1 = "Failed to create
> new session with reason: %s" % vsmcommon . err_to_string [ OOOoo0OO ]
> 2014-03-19 14:08:39 ERROR tlwebaccess[2515]: AttributeError: 'module' object
> has no attribute 'err_to_string'
> 2014-03-19 14:08:39 ERROR tlwebaccess[2515]:
> ----------------------------------------

Revision 28671 prevents the global variable err_to_string from becoming obfuscated.
Comment 4 Henrik Andersson cendio 2014-03-20 07:50:52 CET 
Verified using build 4294, string is now displayed as it should.

Tested using /vsmserver/allowed_groups and provoked following error:

"Failed to create new session with reason: You are not allowed to use ThinLinc"
Comment 5 Karl Mikaelsson cendio 2014-04-10 13:35:22 CEST 
Created attachment 530 [details]
Trying to connect to a stopped vsmserver

The same broken page appears when you try to login to a stopped vsmserver. I'm currently rewriting the error message as part of bug 5027 but the lone password field must go.
Comment 6 Samuel Mannehed cendio 2014-04-15 12:55:53 CEST 
(In reply to comment #5)
> Created an attachment (id=530) [details]
> Trying to connect to a stopped vsmserver
> 
> The same broken page appears when you try to login to a stopped vsmserver. I'm
> currently rewriting the error message as part of bug 5027 but the lone password
> field must go.

Fixed in commit 28848.
Comment 7 Samuel Mannehed cendio 2014-04-15 15:46:51 CEST 
Some code cleanup in commit 28852.
Comment 8 Henrik Andersson cendio 2014-04-16 11:21:51 CEST 
Tested using build 4325, works as expected.
Note You need to log in before you can comment on or make changes to this bug.