Bug 4719 - Profile reordering does not work
Summary: Profile reordering does not work
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Web Administration (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.1.1
Assignee: Aaron Sowry
Keywords: hean01_tester, relnotes
Depends on:
Reported: 2013-06-24 10:02 CEST by Peter Åstrand
Modified: 2013-10-24 10:59 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:


Description Peter Åstrand cendio 2013-06-24 10:02:57 CEST
If you press any of the "Reorder" buttons in the ThinLinc Web Administration, nothing happens.
Comment 1 Aaron Sowry cendio 2013-09-11 13:09:19 CEST
This is because the re-order buttons are <input> tags of type "img", which according to the HTML spec[1] do not send a "value" in their query; they send the coordinates of the click on the image. Our server-side code looks for a "value" key, and it's not finding one.

We could possibly reimplement the buttons as actual <button>s, containing an <img> instead.

[1] http://www.w3.org/TR/html4/interact/forms.html#h-17.4.1
Comment 2 Aaron Sowry cendio 2013-09-11 13:35:14 CEST
Comment 3 Henrik Andersson cendio 2013-10-11 09:23:44 CEST
Tested using Chrome 30, Firefox 24 and IE11. Works as expected.
Comment 4 Pierre Ossman cendio 2013-10-16 14:48:13 CEST
They may work now, but they've been changed to much bigger buttons instead of the smaller icons used before.
Comment 5 Pierre Ossman cendio 2013-10-18 15:56:52 CEST
Going back to an image control is difficult as we have to encode everything in the "name" attribute. Possible, but messy. So the button approach is probably the best solution, but we need to make sure it only renders the image. r28061 uses CSS to kill off the decorations provided by the browser.
Comment 6 Aaron Sowry cendio 2013-10-21 13:21:58 CEST
Had a quick look and am happy with the solution, resolving bug for Henrik to test.
Comment 7 Henrik Andersson cendio 2013-10-21 14:07:21 CEST
Im also happy with the change of appearance, and those buttons work as expected.

Note You need to log in before you can comment on or make changes to this bug.