Bug 4663 - Installer should verify that we have Python 2.X
Summary: Installer should verify that we have Python 2.X
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Server Installer (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.1.1
Assignee: Pierre Ossman
URL:
Keywords: prosaic, samuel_tester
Depends on:
Blocks:
 
Reported: 2013-05-28 09:42 CEST by Peter Åstrand
Modified: 2013-10-24 10:56 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Peter Åstrand cendio 2013-05-28 09:42:24 CEST 
Currently, the installer verifies that our Python is "recent enough":

# Make sure we have valid Python
if ${PYTHON} -c "import sys; sys.exit(sys.hexversion < 0x2040000)"; then
    :
...

However, we do not check that it is a 2.X version, ie *not* Python 3.X, which does not work.
Comment 1 Pierre Ossman cendio 2013-08-13 14:09:13 CEST 
Fixed in r27773.
Comment 2 Samuel Mannehed cendio 2013-10-14 12:49:28 CEST 
[samuel@justina-60 ~]$ PYTHON=python3 thinlinc-nightly/installer/install-server 

Error: A Python interpreter between version 2.4 and 2.7 is required.
I was trying to use the Python interpreter named 'python3'.
If Python is installed under a different name, set the PYTHON
environment variable to the Python binary to use. Example:
PYTHON=/usr/bin/python2.4 sh ./install-server

Looks good.
Note You need to log in before you can comment on or make changes to this bug.