Comment 1 Pierre Ossman 2013-05-15 14:58:32 CEST

Huh. Apparently the following .desktop file works with nautilus:

[root@dhcp-254-223 tl-4.0.0post-server]# cat install-server.desktop 
[Desktop Entry]
Type=Application
Name=Install ThinLinc Server
Exec='./install-server'

It complains if the file isn't executable though.

Comment 2 Pierre Ossman 2013-05-15 15:11:10 CEST

Relative paths are formally not legal according to the desktop specification. This however is:

Exec=sh -c "`dirname %k`/install-server"

Comment 3 Peter Åstrand 2013-11-13 09:41:11 CET

Here's the upstream commit:

https://git.gnome.org/browse/nautilus/commit/?id=72d6c7ce7febd573

I don't agree with any of the presented arguments though.

Comment 4 Aaron Sowry 2013-12-18 13:40:57 CET

Perhaps worth noting is that this also affects the tlclient scripts, which can be a pain if you want to run the dynamic client for example.

Comment 5 Karl Mikaelsson 2015-01-30 17:17:16 CET

One problem with the desktop file approach is that it's hard for us to specify icons. The standard is quite clear on the Icon field - it's either an absolute path to a file (which we can't use) or a name which will be looked up in the system locations (to which we haven't installed anything yet).

Comment 6 Karl Mikaelsson 2015-02-04 11:27:46 CET

I suggest we use the system-software-install icon, which is part of the standard set of icons from the Icon Naming Specification, over at freedesktop.org:

http://standards.freedesktop.org/icon-naming-spec/icon-naming-spec-latest.html

Comment 7 Karl Mikaelsson 2015-02-04 12:40:02 CET

Fixed in r29915.

Comment 8 Henrik Andersson 2015-03-13 09:47:26 CET

Tested and works great on Ubuntu 14.04, the icon is great.

Comment 9 Pierre Ossman 2015-04-21 11:10:50 CEST

The file is now executable, which means that bash and other things might try to execute it, with crappy results.

If you use nautilus to mark a .desktop file as "trusted", it then puts this hash-bang at the top:

#!/usr/bin/env xdg-open

That prevents errors, but tends to open the file in a text editor. So we might need an explaining text in there same as in the shell script.

Comment 10 Pierre Ossman 2015-04-21 11:13:13 CEST

Apparently the text editor thing is a bug:

https://bugzilla.gnome.org/show_bug.cgi?id=343896

However, it is still present which means we need to deal with it.

Comment 11 Karl Mikaelsson 2015-04-21 13:51:29 CEST

(In reply to comment #9)
> The file is now executable, which means that bash and other things might try to
> execute it, with crappy results.
> 
> If you use nautilus to mark a .desktop file as "trusted", it then puts this
> hash-bang at the top:
> 
> #!/usr/bin/env xdg-open
> 
> That prevents errors, but tends to open the file in a text editor. So we might
> need an explaining text in there same as in the shell script.

r30255.

Comment 12 Henrik Andersson 2015-04-23 14:24:40 CEST

Make it clear in README that one should either click the ThinLinc Server Installer icon or run install-server from a terminal.

Comment 13 Karl Mikaelsson 2015-04-24 15:06:47 CEST

(In reply to comment #12)
> Make it clear in README that one should either click the ThinLinc Server
> Installer icon or run install-server from a terminal.

r30266.

Comment 14 Henrik Andersson 2015-04-27 10:17:47 CEST

(In reply to comment #13)
> (In reply to comment #12)
> > Make it clear in README that one should either click the ThinLinc Server
> > Installer icon or run install-server from a terminal.
> 
> r30266.

Looks good.

Comment 15 Henrik Andersson 2015-04-27 10:23:30 CEST

(In reply to comment #14)
> (In reply to comment #13)
> > (In reply to comment #12)
> > > Make it clear in README that one should either click the ThinLinc Server
> > > Installer icon or run install-server from a terminal.
> > 
> > r30266.
> 
> Looks good.

Almost, the README.txt uses "install-server" while the rest "./install-server" which is more proper.

Comment 16 Henrik Andersson 2015-04-27 10:24:11 CEST

Verified "ThinLinc Server Installer" desktop file functionality. Works as expected.

Comment 17 Karl Mikaelsson 2015-04-29 09:33:07 CEST

(In reply to comment #15)
> (In reply to comment #14)
> > (In reply to comment #13)
> > > (In reply to comment #12)
> > > > Make it clear in README that one should either click the ThinLinc Server
> > > > Installer icon or run install-server from a terminal.
> > > 
> > > r30266.
> > 
> > Looks good.
> 
> Almost, the README.txt uses "install-server" while the rest "./install-server"
> which is more proper.

Fixed in r30273: they're all the same as the text in README.txt now.

Comment 18 Henrik Andersson 2015-04-30 08:52:16 CEST

(In reply to comment #17)
> (In reply to comment #15)
> > (In reply to comment #14)
> > > (In reply to comment #13)
> > > > (In reply to comment #12)
> > > > > Make it clear in README that one should either click the ThinLinc Server
> > > > > Installer icon or run install-server from a terminal.
> > > > 
> > > > r30266.
> > > 
> > > Looks good.
> > 
> > Almost, the README.txt uses "install-server" while the rest "./install-server"
> > which is more proper.
> 
> Fixed in r30273: they're all the same as the text in README.txt now.

Looks good, closing..