Bug 4540 - Client should better sanitize input during login
Summary: Client should better sanitize input during login
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Client (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.1.0
Assignee: Pierre Ossman
URL:
Keywords: derfian_tester
Depends on:
Blocks:
 
Reported: 2013-02-12 14:26 CET by Aaron Sowry
Modified: 2013-05-20 16:14 CEST (History)
0 users

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Aaron Sowry cendio 2013-02-12 14:26:59 CET 
If unexpected things are read into the client's buffer during login, it assumes that the server it's trying to connect to does not run ThinLinc. However, it may just be the case that something is writing output before thinlinc-login gets a chance to do its thing - for example, if someone echos something in .bashrc.

We should see if we can somehow try to sanitize the input, or at least log what was actually received. I imagine this will have to be a "best effort" solution.

See issue 14025.
Comment 1 Pierre Ossman cendio 2013-03-07 14:10:00 CET 
This will be done as part of bug 3183.
Comment 2 Pierre Ossman cendio 2013-03-07 14:11:52 CET 
Fixed in r26736.
Comment 3 Karl Mikaelsson cendio 2013-05-20 16:14:47 CEST 
Works great, output is logged to tlclient.log.
Note You need to log in before you can comment on or make changes to this bug.