Bug 4533 - SSH Banner is displayed twice
Summary: SSH Banner is displayed twice
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Client (show other bugs)
Version: trunk
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.9.0
Assignee: Samuel Mannehed
URL:
Keywords: ossman_tester, relnotes
Depends on:
Blocks:
 
Reported: 2013-02-05 14:01 CET by Peter Åstrand
Modified: 2018-02-28 12:44 CET (History)
2 users (show)

See Also:
Acceptance Criteria:


Attachments

Description Peter Åstrand cendio 2013-02-05 14:01:35 CET
SSH allows you to display a "banner" when logging in, for example by adding this to sshd_config:

Banner /etc/issue

The TL client has support for displaying such a banner as a dialog box. However, since you are connecting with SSH twice, the banner will also be displayed two times, which may be confusing for the end user. 

we could consider displaying the banner only when connecting to the master, or the agent. Or, we could avoid the second banner if it has the same contents as the previous one.
Comment 3 Samuel Mannehed cendio 2018-02-15 18:19:41 CET
Tests on Fedora 27 indicate that the fix works well.
Comment 5 Henrik Andersson cendio 2018-02-21 10:16:53 CET
There is a missing entry in release note for this fix.
Comment 7 Samuel Mannehed cendio 2018-02-22 17:27:07 CET
Reopening since we have decided to consider the case where there are two different SSH banners, one on the master and one on the agent. In this case we want to display both of them. The only case where we hide a SSH banner is when the one from the master and the agent are identical.
Comment 10 Samuel Mannehed cendio 2018-02-26 18:43:05 CET
Fixed now. I have tested using two Ubuntu 16.04 servers. The test cases are:

* only banner on agent
* only banner on master
* identical banners on agent and master
* different banners on agent and master
Comment 11 Pierre Ossman cendio 2018-02-28 12:44:03 CET
Tested on Fedora 26:

* no banner on any machine
* only banner on agent
* only banner on master
* identical banners on agent and master
* different banners on agent and master

No problems seen.

Note You need to log in before you can comment on or make changes to this bug.