Bug 4475 - Automatic updates not handled correctly on OS X
Summary: Automatic updates not handled correctly on OS X
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Client (show other bugs)
Version: 4.0.0
Hardware: PC macOS
: P2 Normal
Target Milestone: 4.1.0
Assignee: Karl Mikaelsson
Keywords: hean01_tester
Depends on:
Reported: 2012-11-13 11:22 CET by Aaron Sowry
Modified: 2013-05-07 14:29 CEST (History)
0 users

See Also:
Acceptance Criteria:


Description Aaron Sowry cendio 2012-11-13 11:22:52 CET
This is because tlclient has code paths for updating Windows and !Windows, but OS X doesn't have xdg-open which tlclient tries to use for the update procedure. This should be fixed so that the automatic updates work on OS X as well.
Comment 1 Pierre Ossman cendio 2012-11-20 10:25:24 CET
Add a APPLEINSTALLER to the config as well.
Comment 2 Karl Mikaelsson cendio 2012-11-21 09:14:28 CET
This one seems fairly straight-forward to unbreak, but could take a few hours extra if we want to add some extra polish to the user experience.
Comment 3 Karl Mikaelsson cendio 2012-11-21 18:26:02 CET
After a bit of discussion and investigation I've found that a limitation of our current way of updating is that the default web browser needs to launch the downloaded file after it has finished downloading it, and the behavior of Safari on Mac is to just download the file and put it into the default Downloaded folder. 

(There are a few exceptions - Safari has a "safe files list", but support varies between versions. Using open on a url containing a dmg does not trigger any special behavior in Safari either, they're just downloaded.)

This means that we're leaving the user in the middle of a process, with no clues how to proceed with updating. Therefore, lets refer users to the download page, as with the Linux clients. The idea is to have the user in control the entire upgrade process. I'm willing to reconsider this approach if we can use.

This also means that we really don't need the APPLEINSTALLER configuration key, so the code I've written assumes that the DEFAULTINSTALLER will point to a web site with sufficient links and instructions.

All of this has been commited as r26204.
Comment 4 Karl Mikaelsson cendio 2012-11-26 13:37:31 CET
Seems like I forgot to end a sentence in my last comment.

I'm willing to reconsider this approach if we can use a library such as neon or libcurl for downloading the client instead of offloading it to the OS, or make this process more automatic in other ways.
Comment 5 Henrik Andersson cendio 2013-05-07 14:29:40 CEST
Tested using client build 3937, works as expected both with a client configured with UPDATE_MANDATORY and without.

Note You need to log in before you can comment on or make changes to this bug.