Description Pierre Ossman 2012-11-07 13:05:37 CET

We noticed this when we had problems with evil users on the demo system and had to kill sessions aggressively. At that point we got a bunch of tl-set-sso-helper processes that were stuck in an infinite loop.

After some digging, the offending code is in sso.py in _encryption_key(). It reads the session key, and then duplicates it until it has 16 bytes. The problem is that it fails to handle a key that has been wiped (i.e. is zero characters long). It will then loop forever trying to make the string longer.