Bug 4446 - Firewall configuration fails on unknown distribution families
Summary: Firewall configuration fails on unknown distribution families
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Server Installer (show other bugs)
Version: 3.4.0
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.0.0
Assignee: Aaron Sowry
URL:
Keywords: astrand_tester
Depends on:
Blocks:
 
Reported: 2012-10-23 13:27 CEST by Aaron Sowry
Modified: 2012-11-28 12:43 CET (History)
0 users

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Aaron Sowry cendio 2012-10-23 13:27:35 CEST 
2012-10-23 15:02:48,343: Failed to configure firewall with reason: 'in 
<string>' requires string as left operand, not NoneType

This is due to ctc/tlmisc/tl-setup/modules/thinlinc/tlsetupfirewall.py:79:

elif DISTRIBUTION_FAMILY in (SLE):

They keyword "in" should of course not be used with a singleton, there should be a comparison operator there instead. We should probably check for this in other places too.
Comment 1 Aaron Sowry cendio 2012-10-23 14:53:55 CEST 
Couldn't find any more instances of this error, so fixed in r26055.
Comment 2 Peter Åstrand cendio 2012-10-30 16:10:26 CET 
Looks ok, tested on SLED11.
Note You need to log in before you can comment on or make changes to this bug.