Bug 4214 - raise PyGTK requirement
Summary: raise PyGTK requirement
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Other (show other bugs)
Version: 3.2.0
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.0.0
Assignee: Peter Åstrand
URL:
Keywords: aaron_tester
Depends on:
Blocks:
 
Reported: 2012-02-15 16:36 CET by Pierre Ossman
Modified: 2016-07-01 16:35 CEST (History)
0 users

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Pierre Ossman cendio 2012-02-15 16:36:21 CET 
Currently we require PyGTK 2.4. This version was selected mainly as a consequence of us requiring Python 2.3 (see bug 2765 for details). As we are considering updating the Python requirement (bug 4213), we should also consider upgrading the PyGTK requirement.

RHEL 5 includes PyGTK 2.10, so somewhere around that is probably a good choice.
Comment 1 Aaron Sowry cendio 2012-08-08 14:59:52 CEST 
The PyGTK signal "page-added" which we use in the installer is only present in PyGTK >= 2.10, so we need to have this as a minimum at least.

http://www.pygtk.org/docs/pygtk/class-gtknotebook.html#signal-gtknotebook--page-added
Comment 2 Peter Åstrand cendio 2012-08-09 12:28:44 CEST 
Checked distros:

RHEL 5.8:  2.10
Ubuntu 8.04 LTS: 2.12
SLED11SP2: 2.16

Let's raise req to 2.10.
Comment 3 Peter Åstrand cendio 2012-08-09 12:36:29 CEST 
Fixed in 25590.
Comment 4 Aaron Sowry cendio 2012-09-28 13:00:04 CEST 
Code review looks good, closing.
Note You need to log in before you can comment on or make changes to this bug.