Bug 4064 - pcsctun exits with bad error codes
Summary: pcsctun exits with bad error codes
Status: NEW
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Client (show other bugs)
Version: 3.2.0
Hardware: PC Unknown
: P2 Normal
Target Milestone: LowPrio
Assignee: Peter Åstrand
Depends on:
Reported: 2011-11-21 11:03 CET by Aaron Sowry
Modified: 2017-09-05 13:39 CEST (History)
0 users

See Also:
Acceptance Criteria:


Description Aaron Sowry cendio 2011-11-21 11:03:03 CET
There are a couple of problems with the exit statuses of pcsctun:

- If a socket bind fails, errno is returned *after* a call to g_warning() (main.c, row 1999), which itself modifies errno and gives us a meaningless exit code

- For some reason, for all errors '-errno' is returned. Surely this should be a positive value (i.e. just 'errno')

Perhaps we should print an error message based on the value of errno, and just exit non-zero.

Note You need to log in before you can comment on or make changes to this bug.