Bug 3885 - Avoid error dialog when terminating session from the client
Summary: Avoid error dialog when terminating session from the client
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: Client (show other bugs)
Version: 3.1.2
Hardware: PC Unknown
: P2 Normal
Target Milestone: 3.2.0
Assignee: Pierre Ossman
URL:
Keywords: astrand_tester
Depends on:
Blocks:
 
Reported: 2011-07-12 15:01 CEST by Peter Åstrand
Modified: 2021-11-23 14:35 CET (History)
0 users

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Peter Åstrand cendio 2011-07-12 15:01:39 CEST 
Using 3.2.0 build 3077 and smart card auth. If you pull the card, this will happen:

* An error dialog pops up that says "Connection reset by peer". This is probably because tlclient kills the SSH tunnel. 

* The MS runtime error dialog pops up (vncviewer crashes).

* Both dialogs are closed, likely because tlclient kills vncviewer. 

One solution might be to kill vncviewer first, then shut down the SSH tunnel. 

Related to bug 1560 and bug 3599.
Comment 1 Pierre Ossman cendio 2011-07-12 19:45:02 CEST 
The crash got solved in bug 3599, but we still need to do something about the dialog.
Comment 2 Pierre Ossman cendio 2011-07-12 20:07:06 CEST 
We've decided to simply not pop up an error dialog for this error. The rationale is:

- A crashing Xvnc will still result in Linux sending a proper FIN. Hence we do not get ECONNRESET for that case.

- Network issues will be seen by ssh, not vncviewer. Hence we cannot warn about those from vncviewer.

What's left is internal problems between ssh and vncviewer, and we cannot think of any case where we would like those to pop up an error dialog.
Comment 3 Pierre Ossman cendio 2011-07-12 20:09:25 CEST 
Fixed in r22555.
Comment 4 Peter Åstrand cendio 2011-07-13 14:52:50 CEST 
Works fine now.
Note You need to log in before you can comment on or make changes to this bug.