Bug 3404 - Rewrite the rdesktop smart card implementation
Summary: Rewrite the rdesktop smart card implementation
Status: CLOSED WONTFIX
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: | rdesktop (deprecated) (show other bugs)
Version: 3.0.0
Hardware: PC Unknown
: P2 Normal
Target Milestone: 4.10.0
Assignee: Pierre Ossman
URL:
Keywords:
: 4083 (view as bug list)
Depends on:
Blocks:
 
Reported: 2010-01-26 13:20 CET by Peter Åstrand
Modified: 2019-02-07 15:51 CET (History)
1 user (show)

See Also:
Acceptance Criteria:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Description Peter Åstrand cendio 2010-01-26 13:20:07 CET 
The rdesktop smart card implementation is very bad. It uses locks and threads apparently without reason, has a lot of dead code, and doesn't work correctly on 64 bit platforms. It smells ugly as well. Basically, it needs a complete rewrite.
Comment 1 Pierre Ossman cendio 2012-12-21 12:36:54 CET 
*** Bug 4083 has been marked as a duplicate of this bug. ***
Comment 2 Pierre Ossman cendio 2013-07-05 12:36:13 CEST 
Found another reason for a rewrite. The RDP smart card protocol uses the DCE RPC standard for encoding calls. But rdesktop doesn't make any attempt to properly parse this. Instead it assumes a very fixed layout. This is bound to fail at some point.
Comment 3 Pierre Ossman cendio 2013-07-05 13:45:22 CEST 
(In reply to comment #2)
> Found another reason for a rewrite. The RDP smart card protocol uses the DCE
> RPC standard for encoding calls. But rdesktop doesn't make any attempt to
> properly parse this. Instead it assumes a very fixed layout. This is bound to
> fail at some point.

This is no longer a theoretical problem. Bug 4741 is the first instance of this crappy parsing failing under real world scenarios.
Comment 5 Pierre Ossman cendio 2014-09-05 10:19:23 CEST 
See also bug 3571 about redesigning pcsctun to deal with pcsc-lite's crappiness. Probably need to use a similar design for rdesktop.
Comment 6 Pierre Ossman cendio 2019-02-07 15:43:20 CET 
rdesktop (and associated tools) is being removed from the ThinLinc product.
Note You need to log in before you can comment on or make changes to this bug.