Comment 1 Erik Forsberg 2004-04-01 09:41:01 CEST

Complicated bug, retargeting.

Comment 2 Peter Åstrand 2004-11-08 11:52:10 CET

One simple solution could be to pop up a dialog that says the the clip text is
too large. 

Comment 3 Erik Forsberg 2004-11-22 14:36:23 CET

AFAIK, we haven't heard anyone complaining on not being able to move large
clipboard data chunks. My suggestion is that we move this to 'Future/Ondemand'.

Comment 4 Erik Forsberg 2004-11-22 15:11:27 CET

On the other hand, we'll probably have to fix this in order to be able to fix
bug 491.

Comment 5 Erik Forsberg 2004-11-23 14:14:36 CET

Supporting the INCR protocol is not trivial, but it should be doable.

Basically, when a requestor wants clipboard data from rdesktop, rdesktop should
respond with a property of type INCR containg a number that represents the size
of the clipboard data. The requestor deletes the property which signals to
rdesktop (via a PropertyNotify) that the data transfer should start. Rdesktop
should then send data in suitable chunks to the property named by the requestor
in the initial ConvertSelection call and wait for new PropertyNotify signals. To
end data transfer, a zero-sized data chunk is written to the property on the
requestor.

We're already listening for PropertyChange, so in theory, we should be able to
extend xclip_handle_PropertyNotify and make it send data with INCR. At least,
that's my initial idea.

The other case, receiving data via INCR from other X clients must also be covered. 

Of course, synchronization with the clipboard mechanism of Windows must also
happend, either simply by buffering all data before sending, or more
complicated, by actually sending data as it comes in. One problem might be that
the package size for intermediate Windows clipboard data might be incompatible
with the size of the data received from other clients, so we'll probably have to
buffer anyway.

As a beginning for implementation of this, we need to find other X programs that
behave good so we have something to test against.

Comment 6 Peter Åstrand 2004-11-23 14:55:03 CET

Later, now that bug 491 has been moved. 

Comment 7 Peter Åstrand 2005-06-27 14:22:43 CEST

INCR support has been implemented by Burt Holzman. I've applied the patch to
rdesktop. A new snapshot has been imported to the ctc tree. 

During the 1.4.1 testing, we should verify that INCR works. 

Comment 8 Erik Forsberg 2005-10-13 11:45:38 CEST

I tried to cut'n paste a really large piece of text from OOo to winword on orson. 

Doesn't work, winword hangs with a hourglass for a very long time. 

I'll reopen and retarget to 1.5.0, so we can bugreport and/or find a solution.

Comment 9 Peter Åstrand 2005-10-31 17:12:52 CET

We should checkout
https://sourceforge.net/tracker/?func=detail&atid=381349&aid=1339819&group_id=24366.

Comment 10 Erik Forsberg 2005-11-07 13:29:38 CET

The link in comment#9 is about a patch where the author specifically says
"Didn't touch INCR", so it probably wont help :-).

Comment 11 Erik Forsberg 2005-11-08 09:13:05 CET

Got a patch from Burt Holzman, which makes things work better, although not
perfect. The last lines of the area doesn't get transferred. I've reported this
back to Burt. 

Comment 12 Erik Forsberg 2005-11-08 09:13:54 CET

Created attachment 149 [details]
Patch from Burt. Makes INCR work better, but not perfect.

Comment 13 Erik Forsberg 2005-11-10 10:03:01 CET

Got another patch from Burt that makes earlier failing test case succeed. I've
commited this to rdesktop cvs.

There are still trouble when doing large INCR using native windows clipboard
formats. Burt said he would try to look into this in the near future. 

Comment 14 Erik Forsberg 2005-11-15 17:47:02 CET

Most of the work is done by people on the rdesktop list, we're only testing and
commiting their code.

Comment 15 Pierre Ossman 2014-11-14 11:55:45 CET

Looks like we can send INCR, but not receive it. Need to finish this.

Comment 16 Pierre Ossman 2019-02-07 15:42:44 CET

rdesktop (and associated tools) is being removed from the ThinLinc product.