Bug 2860 - bad /vsmserver/terminalservers causes traceback
Summary: bad /vsmserver/terminalservers causes traceback
Status: CLOSED FIXED
Alias: None
Product: ThinLinc
Classification: Unclassified
Component: VSM Server (show other bugs)
Version: pre-1.0
Hardware: PC All
: P2 Minor
Target Milestone: 4.6.0
Assignee: Pierre Ossman
URL:
Keywords: derfian_tester, prosaic
Depends on:
Blocks:
 
Reported: 2008-08-11 11:30 CEST by Pierre Ossman
Modified: 2016-04-01 11:25 CEST (History)
1 user (show)

See Also:
Acceptance Criteria:


Attachments

Description Pierre Ossman cendio 2008-08-11 11:30:06 CEST
Les discovered that junk (or unknown hosts for that matter) in the terminal server list causes a traceback:

2008-08-05 19:20:33 INFO vsmserver.license: Updating license data from disk to memory
2008-08-05 19:20:33 INFO vsmserver.license: License summary: 200 concurrent users. Hard limit of 220 concurrent users.
2008-08-05 19:20:33 ERROR vsmserver.loadinfo: Unhandled exception fetching load from 10,8.0.204,:904: <class 'socket.gaierror'> (-2, 'Name or service not known') Traceback (most recent call last):
  File "/opt/thinlinc/modules/thinlinc/vsm/xmlrpc.py", line 319, in xmlrpc_call
    self . connect ( ( o00oO0oo0OO , int ( O0O0OOOOoo ) ) )
  File "/usr/lib/python2.5/asyncore.py", line 307, in connect
    err = self.socket.connect_ex(address)
  File "<string>", line 1, in connect_ex
gaierror: (-2, 'Name or service not known')
. Marking agent as down.
2008-08-05 19:20:33 INFO vsmserver.session: Loaded 0 sessions for 0 users from file
2008-08-05 19:34:05 ERROR vsmserver.loadinfo: Unhandled exception fetching load from 10.8.0.204,:904: <class 'socket.gaierror'> (-2, 'Name or service not known') Traceback (most recent call last):
  File "/opt/thinlinc/modules/thinlinc/vsm/xmlrpc.py", line 319, in xmlrpc_call
    self . connect ( ( o00oO0oo0OO , int ( O0O0OOOOoo ) ) )
  File "/usr/lib/python2.5/asyncore.py", line 307, in connect
    err = self.socket.connect_ex(address)
  File "<string>", line 1, in connect_ex
gaierror: (-2, 'Name or service not known')
. Marking agent as down.
Comment 1 Aaron Sowry cendio 2010-08-20 11:17:09 CEST
This bug also occurs if unknown/bad hosts are listed in /vsmserver/explicit_agentselection
Comment 2 Aaron Sowry cendio 2013-10-08 15:13:11 CEST
Reported again in issue 14610. Reassigning for discussion.
Comment 3 Karl Mikaelsson cendio 2015-11-17 13:12:11 CET
We have similar problems when we get temporary name resolution errors, reported in issue 17976.
Comment 9 Pierre Ossman cendio 2015-12-28 15:59:56 CET
All done. Need to test:

 - Invalid names for terminalservers (both syntax and names that cannot be looked up)

 - Other socket errors in XML-RPC connection (e.g. ECONNREFUSED)

 - Bad listen_hostname for vsmagent and vsmserver.
Comment 13 Karl Mikaelsson cendio 2016-01-04 15:54:37 CET
(In reply to comment #9)
> All done. Need to test:
> 
>  - Invalid names for terminalservers (both syntax and names that cannot be
> looked up)

Handles everything I've thrown at it with grace.
 
>  - Other socket errors in XML-RPC connection (e.g. ECONNREFUSED)

> 2016-01-04 15:38:21 WARNING vsmserver.loadinfo: [Errno 111] Connection refused talking to VSM Agent 127.0.0.1:904 in request for loadinfo. Marking as down.
> 2016-01-04 15:36:23 WARNING vsmserver.loadinfo: [Errno -9] Address family for hostname not supported talking to VSM Agent ::1:904 in request for loadinfo. Marking as down.
> 2016-01-04 15:36:23 WARNING vsmserver.loadinfo: [Errno -2] Name or service not known talking to VSM Agent [2a00:801:107:4700:20c:29ff:fe00:9a5a]:904 in request for loadinfo. Marking as down.

Ayup.
 
>  - Bad listen_hostname for vsmagent and vsmserver.

Works fine, with similar log entries for both vsmserver and vsmagent:

> 2016-01-04 15:35:03 ERROR vsmserver: Unhandled socket error [Errno -2] Name or service not known
> 2016-01-04 15:35:03 ERROR vsmserver: Exiting

Note You need to log in before you can comment on or make changes to this bug.